fixes needed to get smoke tests passing

fixes needed to get smoke tests passing

[Siggi Cherem (dart-lang), 2014-08-06 02:58:41]

https://codereview.chromium.org/444843003/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/engine.dart (left):

https://codereview.chromium.org/444843003/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:12662: void logError2(String message,
Exception exception);
I think Pete run into this too. This change is not needed to get the smoke test
passing, but whenever tests fail in checked mode, they end up failing again here
because of a type-error, so the original error gets lost.

It would be good if we could get rid of these type annotations.

[scheglov, 2014-08-06 03:09:24]

LGTM

Do you want to commit this CL (after https://codereview.chromium.org/428303004)
or me to merge into?

[Siggi Cherem (dart-lang), 2014-08-06 03:16:52]

On 2014/08/06 03:09:24, scheglov wrote:
> LGTM
> 
> Do you want to commit this CL (after
https://codereview.chromium.org/428303004)
> or me to merge into?

If you can merge it into, that would be best. Especially since I believe the
changes in engine might need to be done in Java as well (not sure?)

[scheglov, 2014-08-06 04:03:09]

On 2014/08/06 03:16:52, Siggi Cherem (dart-lang) wrote:
> On 2014/08/06 03:09:24, scheglov wrote:
> > LGTM
> > 
> > Do you want to commit this CL (after
> https://codereview.chromium.org/428303004)
> > or me to merge into?
> 
> If you can merge it into, that would be best. Especially since I believe the
> changes in engine might need to be done in Java as well (not sure?)

Merged into https://codereview.chromium.org/428303004