fixes needed to get smoke tests passing

pkg/analyzer/lib/src/generated/engine.dart

Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 3abda106c752697b075ff2514783c21cccc4a1d6..a1c0bd57964d6b0c27a1ed1b6488fedbf2d6f0cb 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -12659,7 +12659,7 @@ abstract class Logger {
    * @param message an explanation of why the error occurred or what it means
    * @param exception the exception being logged
    */
-  void logError2(String message, Exception exception);

[Siggi Cherem (dart-lang), 2014/08/06 02:58:40]

I think Pete run into this too. This change is not needed to get the smoke test
passing, but whenever tests fail in checked mode, they end up failing again here
because of a type-error, so the original error gets lost.

It would be good if we could get rid of these type annotations.

+  void logError2(String message, exception);
 
   /**
    * Log the given informational message.
@@ -12687,7 +12687,7 @@ class Logger_NullLogger implements Logger {
   }
 
   @override
-  void logError2(String message, Exception exception) {
+  void logError2(String message, exception) {
   }
 
   @override
@@ -12695,7 +12695,7 @@ class Logger_NullLogger implements Logger {
   }
 
   @override
-  void logInformation2(String message, Exception exception) {
+  void logInformation2(String message, exception) {
   }
 }
 
@@ -15741,4 +15741,4 @@ class WorkManager_WorkIterator {
       }
     }
   }
-}
+}