Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5830)

Unified Diff: chrome/renderer/resources/extensions/web_view_experimental.js

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't crash on tear down Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view_experimental.js
diff --git a/chrome/renderer/resources/extensions/web_view_experimental.js b/chrome/renderer/resources/extensions/web_view_experimental.js
index 40184cf067b9732f70b7d61f27992a00e62a815d..7a84feeda8d498e1f007c50bdcfec9e34de7cb48 100644
--- a/chrome/renderer/resources/extensions/web_view_experimental.js
+++ b/chrome/renderer/resources/extensions/web_view_experimental.js
@@ -111,7 +111,7 @@ WebViewInternal.prototype.maybeHandleContextMenu = function(e, webViewEvent) {
validateCall();
// TODO(lazyboy): WebViewShowContextFunction doesn't do anything useful
// with |items|, implement.
- WebView.showContextMenu(self.instanceId, requestId, items);
+ WebView.showContextMenu(self.guestInstanceId, requestId, items);
}
};
webViewEvent.menu = menu;
@@ -123,7 +123,7 @@ WebViewInternal.prototype.maybeHandleContextMenu = function(e, webViewEvent) {
if (!defaultPrevented) {
actionTaken = true;
// The default action is equivalent to just showing the context menu as is.
- WebView.showContextMenu(self.instanceId, requestId, undefined);
+ WebView.showContextMenu(self.guestInstanceId, requestId, undefined);
// TODO(lazyboy): Figure out a way to show warning message only when
// listeners are registered for this event.
@@ -141,7 +141,7 @@ WebViewInternal.prototype.maybeGetExperimentalPermissions = function() {
/** @private */
WebViewInternal.prototype.captureVisibleRegion = function(spec, callback) {
- WebView.captureVisibleRegion(this.instanceId, spec, callback);
+ WebView.captureVisibleRegion(this.guestInstanceId, spec, callback);
};
WebViewInternal.maybeRegisterExperimentalAPIs = function(proto) {
« no previous file with comments | « chrome/renderer/resources/extensions/web_view_events.js ('k') | content/browser/browser_plugin/browser_plugin_embedder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698