content/browser/browser_plugin/browser_plugin_embedder.h - Issue 444813002: Remove BrowserPlugin's -internal-attach method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't crash on tear down Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_embedder.h

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h

index a173fec74fa36e6f0dea05fd1be8338e924e68f3..e894df4fc2cbab1e104e729516913937dd7b172c 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.h

+++ b/content/browser/browser_plugin/browser_plugin_embedder.h

@@ -85,14 +85,12 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {

// |instance_id|.

void OnGuestCallback(int instance_id,

const BrowserPluginHostMsg_Attach_Params& params,

- const base::DictionaryValue* extra_params,

WebContents* guest_web_contents);

// Message handlers.

void OnAttach(int instance_id,

- const BrowserPluginHostMsg_Attach_Params& params,

- const base::DictionaryValue& extra_params);

+ const BrowserPluginHostMsg_Attach_Params& params);

void OnPluginAtPositionResponse(int instance_id,

int request_id,

const gfx::Point& position);