Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index 2360ee0bad1fb826197cccc751eaaa2fe8778523..921ba7cce416ea128861fa26b3f8b8fe34bc70a2 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -192,11 +192,9 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
return web_contents();
}
- // Returns the extra parameters associated with this GuestView passed
- // in from JavaScript.
- base::DictionaryValue* extra_params() const {
- return extra_params_.get();
- }
+ // Returns the parameters associated with the element hosting this GuestView
+ // passed in from JavaScript.
+ base::DictionaryValue* attach_params() const { return attach_params_.get(); }
// Returns whether this guest has an associated embedder.
bool attached() const { return !!embedder_web_contents_; }
@@ -222,6 +220,8 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
return opener_.get();
}
+ // Sets some additional chrome/ initialization parameters.
+ void SetAttachParams(const base::DictionaryValue& params);
void SetOpener(GuestViewBase* opener);
// RenderProcessHostObserver implementation
@@ -241,8 +241,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
virtual void RegisterDestructionCallback(
const DestructionCallback& callback) OVERRIDE FINAL;
virtual void WillAttach(
- content::WebContents* embedder_web_contents,
- const base::DictionaryValue& extra_params) OVERRIDE FINAL;
+ content::WebContents* embedder_web_contents) OVERRIDE FINAL;
// Dispatches an event |event_name| to the embedder with the |event| fields.
void DispatchEventToEmbedder(Event* event);
@@ -299,11 +298,11 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
DestructionCallback destruction_callback_;
- // The extra parameters associated with this GuestView passed
- // in from JavaScript. This will typically be the view instance ID,
- // the API to use, and view-specific parameters. These parameters
- // are passed along to new guests that are created from this guest.
- scoped_ptr<base::DictionaryValue> extra_params_;
+ // The parameters associated with the element hosting this GuestView that
+ // are passed in from JavaScript. This will typically be the view instance ID,
+ // and element-specific parameters. These parameters are passed along to new
+ // guests that are created from this guest.
+ scoped_ptr<base::DictionaryValue> attach_params_;
scoped_ptr<EmbedderWebContentsObserver> embedder_web_contents_observer_;

Powered by Google App Engine
This is Rietveld 408576698