Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index a1557d55ad8ecf25e8b1bbae982d94705bab8697..963c0b52b7c6e93a5ca4ad5d0cec6b59b136c1fa 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -322,6 +322,12 @@ void GuestViewBase::GuestSizeChanged(const gfx::Size& old_size,
GuestSizeChangedDueToAutoSize(old_size, new_size);
}
+void GuestViewBase::SetAttachParams(const base::DictionaryValue& params) {
+ attach_params_.reset(params.DeepCopy());
+ attach_params_->GetInteger(guestview::kParameterInstanceId,
+ &view_instance_id_);
+}
+
void GuestViewBase::SetOpener(GuestViewBase* guest) {
if (guest && guest->IsViewType(GetViewType())) {
opener_ = guest->AsWeakPtr();
@@ -335,8 +341,7 @@ void GuestViewBase::RegisterDestructionCallback(
destruction_callback_ = callback;
}
-void GuestViewBase::WillAttach(content::WebContents* embedder_web_contents,
- const base::DictionaryValue& extra_params) {
+void GuestViewBase::WillAttach(content::WebContents* embedder_web_contents) {
// After attachment, this GuestViewBase's lifetime is restricted to the
// lifetime of its embedder WebContents. Observing the RenderProcessHost
// of the embedder is no longer necessary.
@@ -344,8 +349,6 @@ void GuestViewBase::WillAttach(content::WebContents* embedder_web_contents,
embedder_web_contents_ = embedder_web_contents;
embedder_web_contents_observer_.reset(
new EmbedderWebContentsObserver(this));
- extra_params.GetInteger(guestview::kParameterInstanceId, &view_instance_id_);
- extra_params_.reset(extra_params.DeepCopy());
WillAttachToEmbedder();
}

Powered by Google App Engine
This is Rietveld 408576698