Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 444223002: Wrap NV_path_rendering API with GrGLPathRendering (Closed)

Created:
6 years, 4 months ago by Chris Dalton
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Wrap NV_path_rendering API with GrGLPathRendering Adds a GrGLPathRendering class that wraps the NV_path_rendering extension and manages its various API versions. It also provides backup implementations when certain NVpr methods from later API versions are not present on the current system. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c7103a104fdc7150b4e3c0d3efc42735ad359616

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -238 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 3 chunks +2 lines, -111 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 chunks +19 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLPath.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 4 chunks +13 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLPathRange.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRange.cpp View 3 chunks +6 lines, -15 lines 0 comments Download
A src/gpu/gl/GrGLPathRendering.h View 1 chunk +108 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +281 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 10 chunks +40 lines, -68 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Chris Dalton
The bug was in GrGpuGL_program.cpp. It was abandoning the path rendering resources without checking if ...
6 years, 4 months ago (2014-08-06 23:17:18 UTC) #1
Chris Dalton
Adding Brian
6 years, 4 months ago (2014-08-07 22:03:00 UTC) #2
Kimmo Kinnunen
./gyp_skia && ninja -C out/Debug/ dm && gdb --args ./out/Debug/dm --config nvprmsaa4 -w p --abandonGpuContext ...
6 years, 4 months ago (2014-08-08 12:39:45 UTC) #3
Chris Dalton
On 2014/08/08 12:39:45, kkinnunen wrote: > ./gyp_skia && ninja -C out/Debug/ dm && gdb --args ...
6 years, 4 months ago (2014-08-11 18:57:55 UTC) #4
bsalomon
lgtm
6 years, 4 months ago (2014-08-11 19:03:04 UTC) #5
Chris Dalton
The CQ bit was checked by cdalton@nvidia.com
6 years, 4 months ago (2014-08-11 19:37:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/444223002/1
6 years, 4 months ago (2014-08-11 19:37:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 19:38:03 UTC) #8
commit-bot: I haz the power
Failed to apply patch for gyp/gpu.gypi: While running git apply --index -p1; error: patch failed: ...
6 years, 4 months ago (2014-08-11 19:38:04 UTC) #9
Chris Dalton
The CQ bit was checked by cdalton@nvidia.com
6 years, 4 months ago (2014-08-11 20:56:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/444223002/20001
6 years, 4 months ago (2014-08-11 20:56:31 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 21:05:12 UTC) #12
Message was sent while issue was closed.
Change committed as c7103a104fdc7150b4e3c0d3efc42735ad359616

Powered by Google App Engine
This is Rietveld 408576698