cc: Prevent unit tests from using Now() as the impl frame time.

cc: Prevent unit tests from using Now() as the impl frame time.

Unit tests using FakeLayerTreeHostImpl should not use Now() as the
frame time, as this is racey/problematic. For instance it may not change
fast enough to let your test produce 2 outputs at different Now() times.

Re-enable 2 tests that were failing because of this problem in the test
harness.

R=enne, jbedley
BUG=393733
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288029

[enne (OOO), 2014-08-06 23:49:38]

lgtm

https://codereview.chromium.org/444053004/diff/1/cc/test/fake_layer_tree_host...
File cc/test/fake_layer_tree_host_impl.cc (right):

https://codereview.chromium.org/444053004/diff/1/cc/test/fake_layer_tree_host...
cc/test/fake_layer_tree_host_impl.cc:23: // Avoid using Now() as the frame time
in unit tests.
Random thought: is this something we could/should presubmit ban, in another
test?

[danakj, 2014-08-07 03:36:11]

https://codereview.chromium.org/444053004/diff/1/cc/test/fake_layer_tree_host...
File cc/test/fake_layer_tree_host_impl.cc (right):

https://codereview.chromium.org/444053004/diff/1/cc/test/fake_layer_tree_host...
cc/test/fake_layer_tree_host_impl.cc:23: // Avoid using Now() as the frame time
in unit tests.
On 2014/08/06 23:49:38, enne wrote:
> Random thought: is this something we could/should presubmit ban, in another
> test?

Well. Its not the tests doing Now() explicitly. Its that they didn't set a
current frame time ticks. And LTHI uses Now(). Its horrible and we should make
LTHI stop using Now() really. Not sure how to guard this for other tests tho :/

[danakj, 2014-08-07 03:36:19]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-07 03:37:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/444053004/1

[commit-bot: I haz the power, 2014-08-07 11:06:18]

Change committed as 288029