Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 444053004: cc: Prevent unit tests from using Now() as the impl frame time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/test/fake_layer_tree_host_impl.cc » ('j') | cc/test/fake_layer_tree_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index 26cae9c0bef3d0a37c1c67880aa9a14f17b2d9f6..5eae6a6c52ae72d544d5985f29221da8d7b4562d 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -494,10 +494,6 @@ TEST_F(PictureLayerImplTest, InvalidViewportForPrioritizingTiles) {
}
TEST_F(PictureLayerImplTest, InvalidViewportAfterReleaseResources) {
- base::TimeTicks time_ticks;
- time_ticks += base::TimeDelta::FromMilliseconds(1);
- host_impl_.SetCurrentFrameTimeTicks(time_ticks);
-
gfx::Size tile_size(100, 100);
gfx::Size layer_bounds(400, 400);
@@ -2764,10 +2760,6 @@ TEST_F(NoLowResPictureLayerImplTest, InvalidViewportForPrioritizingTiles) {
}
TEST_F(NoLowResPictureLayerImplTest, InvalidViewportAfterReleaseResources) {
- base::TimeTicks time_ticks;
- time_ticks += base::TimeDelta::FromMilliseconds(1);
- host_impl_.SetCurrentFrameTimeTicks(time_ticks);
-
gfx::Size tile_size(100, 100);
gfx::Size layer_bounds(400, 400);
@@ -3168,15 +3160,12 @@ class OcclusionTrackingPictureLayerImplTest : public PictureLayerImplTest {
}
};
-#if defined(OS_WIN)
-#define MAYBE_OccludedTilesSkippedDuringRasterization \
- DISABLED_OccludedTilesSkippedDuringRasterization
-#else
-#define MAYBE_OccludedTilesSkippedDuringRasterization \
- OccludedTilesSkippedDuringRasterization
-#endif
TEST_F(OcclusionTrackingPictureLayerImplTest,
- MAYBE_OccludedTilesSkippedDuringRasterization) {
+ OccludedTilesSkippedDuringRasterization) {
+ base::TimeTicks time_ticks;
+ time_ticks += base::TimeDelta::FromMilliseconds(1);
+ host_impl_.SetCurrentFrameTimeTicks(time_ticks);
+
gfx::Size tile_size(102, 102);
gfx::Size layer_bounds(1000, 1000);
gfx::Size viewport_size(500, 500);
@@ -3219,6 +3208,8 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
layer1->SetContentsOpaque(true);
layer1->SetPosition(occluding_layer_position);
+ time_ticks += base::TimeDelta::FromMilliseconds(200);
+ host_impl_.SetCurrentFrameTimeTicks(time_ticks);
host_impl_.pending_tree()->UpdateDrawProperties();
unoccluded_tile_count = 0;
@@ -3240,6 +3231,8 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
// Full occlusion.
layer1->SetPosition(gfx::Point(0, 0));
+ time_ticks += base::TimeDelta::FromMilliseconds(200);
+ host_impl_.SetCurrentFrameTimeTicks(time_ticks);
host_impl_.pending_tree()->UpdateDrawProperties();
unoccluded_tile_count = 0;
@@ -3259,14 +3252,12 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
EXPECT_EQ(unoccluded_tile_count, 0);
}
-#if defined(OS_WIN)
-#define MAYBE_OccludedTilesNotMarkedAsRequired \
- DISABLED_OccludedTilesNotMarkedAsRequired
-#else
-#define MAYBE_OccludedTilesNotMarkedAsRequired OccludedTilesNotMarkedAsRequired
-#endif
TEST_F(OcclusionTrackingPictureLayerImplTest,
- MAYBE_OccludedTilesNotMarkedAsRequired) {
+ OccludedTilesNotMarkedAsRequired) {
+ base::TimeTicks time_ticks;
+ time_ticks += base::TimeDelta::FromMilliseconds(1);
+ host_impl_.SetCurrentFrameTimeTicks(time_ticks);
+
gfx::Size tile_size(102, 102);
gfx::Size layer_bounds(1000, 1000);
gfx::Size viewport_size(500, 500);
@@ -3314,6 +3305,8 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
layer1->SetContentsOpaque(true);
layer1->SetPosition(occluding_layer_position);
+ time_ticks += base::TimeDelta::FromMilliseconds(200);
+ host_impl_.SetCurrentFrameTimeTicks(time_ticks);
host_impl_.pending_tree()->UpdateDrawProperties();
for (size_t i = 0; i < pending_layer_->num_tilings(); ++i) {
@@ -3350,6 +3343,8 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
// Full occlusion.
layer1->SetPosition(gfx::PointF(0, 0));
+ time_ticks += base::TimeDelta::FromMilliseconds(200);
+ host_impl_.SetCurrentFrameTimeTicks(time_ticks);
host_impl_.pending_tree()->UpdateDrawProperties();
for (size_t i = 0; i < pending_layer_->num_tilings(); ++i) {
« no previous file with comments | « no previous file | cc/test/fake_layer_tree_host_impl.cc » ('j') | cc/test/fake_layer_tree_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698