content/browser/screen_orientation/screen_orientation_dispatcher_host.h - Issue 444033002: Fix screen.orientation.lock() rejection and an integration test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/screen_orientation/screen_orientation_dispatcher_host.h

Issue 444033002: Fix screen.orientation.lock() rejection and an integration test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix lock reject on non-Android Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/screen_orientation/screen_orientation_browsertest.cc ('k') | content/browser/screen_orientation/screen_orientation_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/screen_orientation/screen_orientation_dispatcher_host.h

diff --git a/content/browser/screen_orientation/screen_orientation_dispatcher_host.h b/content/browser/screen_orientation/screen_orientation_dispatcher_host.h

index 61d1938d6717d704ea2f9a3e57bb13aaccb053b5..e0019903b30893faac466b6d87b89b4dbd7c2c0c 100644

--- a/content/browser/screen_orientation/screen_orientation_dispatcher_host.h

+++ b/content/browser/screen_orientation/screen_orientation_dispatcher_host.h

@@ -48,6 +48,12 @@ class CONTENT_EXPORT ScreenOrientationDispatcherHost

void ResetCurrentLock();

+ // Like NotifyLockError(int, blink::WebLockOrientationError but expected to be

+ // used internally when the RenderFrameHost is known.

Michael van Ouwerkerk 2014/08/07 10:34:12 This comment seems brittle, I don't like the way i

+ void NotifyLockError(int request_id,

+ RenderFrameHost* render_frame_host,

+ blink::WebLockOrientationError error);

scoped_ptr<ScreenOrientationProvider> provider_;

struct LockInformation {