Fix screen.orientation.lock() rejection and an integration test.

content/browser/screen_orientation/screen_orientation_dispatcher_host.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_DISPATCHER_HOST_H_
 #define CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_DISPATCHER_HOST_H_
 
 #include "base/id_map.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents_observer.h"
@@ skipping 30 matching lines @@
                      blink::WebScreenOrientationLockType orientation,
                      int request_id);
   void OnUnlockRequest(RenderFrameHost* render_frame_host);
 
   // Returns a RenderFrameHost if the request_id is still valid and the
   // associated RenderFrameHost still exists. Returns NULL otherwise.
   RenderFrameHost* GetRenderFrameHostForRequestID(int request_id);
 
   void ResetCurrentLock();
 
+  // Like NotifyLockError(int, blink::WebLockOrientationError but expected to be
+  // used internally when the RenderFrameHost is known.

[Michael van Ouwerkerk, 2014/08/07 10:34:12]

This comment seems brittle, I don't like the way it refers to another method.
How about actually documenting the public methods, and let people assume the
private ones are just helpers?

+  void NotifyLockError(int request_id,
+                       RenderFrameHost* render_frame_host,
+                       blink::WebLockOrientationError error);
+
   scoped_ptr<ScreenOrientationProvider> provider_;
 
   struct LockInformation {
     LockInformation(int request_id, int process_id, int routing_id);
     int request_id;
     int process_id;
     int routing_id;
   };
   // current_lock_ will be NULL if there are no current lock.
   LockInformation* current_lock_;
 
   DISALLOW_COPY_AND_ASSIGN(ScreenOrientationDispatcherHost);
 };
 
 }  // namespace content
 
 #endif // CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_DISPATCHER_HOST_H_