Fix screen.orientation.lock() rejection and an integration test.

Fix screen.orientation.lock() rejection and an integration test.

Unfortunately, we can't do more than a smoke test because Chromium
doesn't support fullscreen on Android. See http://crbug.com/401114

BUG=162827
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288048

[Michael van Ouwerkerk, 2014-08-06 16:41:41]

lgtm

[mlamouri (slow - plz ping), 2014-08-06 16:43:52]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-08-06 16:45:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/444033002/20001

[commit-bot: I haz the power, 2014-08-06 20:30:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-06 21:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 21:03:20]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2014-08-07 10:30:38]

The test was failing because... the feature was broken on non-Android. This is
now fixed... and tested! ;)

[mlamouri (slow - plz ping), 2014-08-07 10:30:55]

On 2014/08/07 10:30:38, Mounir Lamouri wrote:
> The test was failing because... the feature was broken on non-Android. This is
> now fixed... and tested! ;)

PTAL

[Michael van Ouwerkerk, 2014-08-07 10:34:12]

https://codereview.chromium.org/444033002/diff/40001/content/browser/screen_o...
File content/browser/screen_orientation/screen_orientation_dispatcher_host.h
(right):

https://codereview.chromium.org/444033002/diff/40001/content/browser/screen_o...
content/browser/screen_orientation/screen_orientation_dispatcher_host.h:52: //
used internally when the RenderFrameHost is known.
This comment seems brittle, I don't like the way it refers to another method.
How about actually documenting the public methods, and let people assume the
private ones are just helpers?

[mlamouri (slow - plz ping), 2014-08-07 10:39:24]

Review comments applied. PTAL.

[Michael van Ouwerkerk, 2014-08-07 10:54:12]

lgtm again, thanks

[mlamouri (slow - plz ping), 2014-08-07 11:07:47]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-08-07 11:09:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/444033002/60001

[commit-bot: I haz the power, 2014-08-07 15:42:06]

Change committed as 288048