Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 443983002: MIPS: Fix build after r22923. (Closed)

Created:
6 years, 4 months ago by akos.palfi.imgtec
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Fix build after r22923. The name "zero" is in conflict with fdlibm's "zero" constant. This commit renames MIPS "zero" to "Zero". BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/constants-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/constants-mips64.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
akos.palfi.imgtec
PTAL.
6 years, 4 months ago (2014-08-06 13:16:21 UTC) #1
Yang
On 2014/08/06 13:16:21, akos.palfi.imgtec wrote: > PTAL. I think I'll simply move fdlibm into another ...
6 years, 4 months ago (2014-08-06 13:18:13 UTC) #2
akos.palfi.imgtec
On 2014/08/06 13:18:13, Yang wrote: > On 2014/08/06 13:16:21, akos.palfi.imgtec wrote: > > PTAL. > ...
6 years, 4 months ago (2014-08-06 13:22:08 UTC) #3
Yang
On 2014/08/06 13:22:08, akos.palfi.imgtec wrote: > On 2014/08/06 13:18:13, Yang wrote: > > On 2014/08/06 ...
6 years, 4 months ago (2014-08-06 13:39:47 UTC) #4
akos.palfi.imgtec
6 years, 4 months ago (2014-08-06 13:48:16 UTC) #5
Closing.. Fixed by r22933.

Powered by Google App Engine
This is Rietveld 408576698