Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 443903004: [CC]: Reduce required precision for TransformNormal test. (Closed)

Created:
6 years, 4 months ago by rmcilroy
Modified:
6 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

[CC]: Reduce required precision for TransformNormal test. This CL changes the precision requirements for DrawPolygonTransformTest.TransformNormal. This is required since it currently fails on Arm64 due to gcc's use of a fused multiple instruction on mapMScalars. Details of this issue are available on the associated bug. BUG=401117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287871

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M cc/quads/draw_polygon_unittest.cc View 3 chunks +11 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
rmcilroy
Sami, could you please take a look, thanks.
6 years, 4 months ago (2014-08-06 16:38:04 UTC) #1
Sami
https://codereview.chromium.org/443903004/diff/1/cc/quads/draw_polygon_unittest.cc File cc/quads/draw_polygon_unittest.cc (right): https://codereview.chromium.org/443903004/diff/1/cc/quads/draw_polygon_unittest.cc#newcode20 cc/quads/draw_polygon_unittest.cc:20: EXPECT_TRUE(std::abs(a - b) < std::numeric_limits<float>::epsilon()); I think in general ...
6 years, 4 months ago (2014-08-06 17:09:24 UTC) #2
Sami
Ack, thanks for pointing out that the macro name already does what I suggested :) ...
6 years, 4 months ago (2014-08-06 17:14:23 UTC) #3
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-06 17:37:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/443903004/1
6 years, 4 months ago (2014-08-06 17:37:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-06 21:07:53 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 22:09:19 UTC) #7
Message was sent while issue was closed.
Change committed as 287871

Powered by Google App Engine
This is Rietveld 408576698