v8::TryCatch should cancel the scheduled exception on Reset.

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 5096 matching lines @@
    * Returns the message associated with this exception.  If there is
    * no message associated an empty handle is returned.
    *
    * The returned handle is valid until this TryCatch block has been
    * destroyed.
    */
   Local<v8::Message> Message() const;
 
   /**
    * Clears any exceptions that may have been caught by this try/catch block.
-   * After this method has been called, HasCaught() will return false.
+   * After this method has been called, HasCaught() will return false. Cancels
+   * the scheduled exception if it is caught and ReThrow() is not called before.
    *
    * It is not necessary to clear a try/catch block before using it again; if
    * another exception is thrown the previously caught exception will just be
    * overwritten.  However, it is often a good idea since it makes it easier
    * to determine which operation threw a given exception.
    */
   void Reset();
 
   /**
    * Set verbosity of the external exception handler.
@@ skipping 28 matching lines @@
     return handler->js_stack_comparable_address_;
   }
 
  private:
   // Make it hard to create heap-allocated TryCatch blocks.
   TryCatch(const TryCatch&);
   void operator=(const TryCatch&);
   void* operator new(size_t size);
   void operator delete(void*, size_t);
 
+  void ResetInternal();

[Michael Starzinger, 2014/08/07 08:40:36]

nit: Can we move this up a few lines to before constructors are overridden? I'll
do this while landing if you don't mind.

[yhirano, 2014/08/07 08:50:54]

For readability? Then it is OK to do so.

[Michael Starzinger, 2014/08/07 08:53:53]

Yes, for readability and consistency with the rest of the file.

+
   v8::internal::Isolate* isolate_;
   v8::TryCatch* next_;
   void* exception_;
   void* message_obj_;
   void* message_script_;
   void* js_stack_comparable_address_;
   int message_start_pos_;
   int message_end_pos_;
   bool is_verbose_ : 1;
   bool can_continue_ : 1;
@@ skipping 1553 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_