extensions: Register 'app' and 'webstore' bindings only if they are available.

chrome/common/extensions/api/extension_api_unittest.cc

Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index 58c72ac362f6ea7785235ef66838cd0dacb63248..f4ff18660d50d1f126968b43187ab3722e7bb628 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -673,9 +673,9 @@ TEST(ExtensionAPITest, URLMatching) {
   EXPECT_TRUE(MatchesURL(api.get(), "app", "https://blah.net"));
   EXPECT_TRUE(MatchesURL(api.get(), "app", "file://somefile.html"));
 
-  // But not internal URLs.
-  EXPECT_FALSE(MatchesURL(api.get(), "app", "about:flags"));
-  EXPECT_FALSE(MatchesURL(api.get(), "app", "chrome://flags"));
+  // Also to internal URLs.
+  EXPECT_TRUE(MatchesURL(api.get(), "app", "about:flags"));
+  EXPECT_TRUE(MatchesURL(api.get(), "app", "chrome://flags"));

[not at google - send to devlin, 2014/08/06 17:26:18]

Ah I think you caught an actual bug here. we should be validating that
<all_urls> doesn't include chrome: and about: URLs.

you may need to check PermisisonsData::IsRestrictedUrl in simple_feature.cc:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

[sadrul, 2014/08/06 18:51:51]

Done.

 
   // "app" should be available to chrome-extension URLs.
   EXPECT_TRUE(MatchesURL(api.get(), "app",