extensions: Register 'app' and 'webstore' bindings only if they are available.

chrome/common/extensions/api/extension_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_api.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
@@ skipping 655 matching lines @@
 }
 
 TEST(ExtensionAPITest, URLMatching) {
   scoped_ptr<ExtensionAPI> api(ExtensionAPI::CreateWithDefaultConfiguration());
 
   // "app" API is available to all URLs that content scripts can be injected.
   EXPECT_TRUE(MatchesURL(api.get(), "app", "http://example.com/example.html"));
   EXPECT_TRUE(MatchesURL(api.get(), "app", "https://blah.net"));
   EXPECT_TRUE(MatchesURL(api.get(), "app", "file://somefile.html"));
 
-  // But not internal URLs.
-  EXPECT_FALSE(MatchesURL(api.get(), "app", "about:flags"));
-  EXPECT_FALSE(MatchesURL(api.get(), "app", "chrome://flags"));
+  // Also to internal URLs.
+  EXPECT_TRUE(MatchesURL(api.get(), "app", "about:flags"));
+  EXPECT_TRUE(MatchesURL(api.get(), "app", "chrome://flags"));

[not at google - send to devlin, 2014/08/06 17:26:18]

Ah I think you caught an actual bug here. we should be validating that
<all_urls> doesn't include chrome: and about: URLs.

you may need to check PermisisonsData::IsRestrictedUrl in simple_feature.cc:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

[sadrul, 2014/08/06 18:51:51]

Done.

 
   // "app" should be available to chrome-extension URLs.
   EXPECT_TRUE(MatchesURL(api.get(), "app",
                           "chrome-extension://fakeextension"));
 
   // "storage" API (for example) isn't available to any URLs.
   EXPECT_FALSE(MatchesURL(api.get(), "storage",
                           "http://example.com/example.html"));
   EXPECT_FALSE(MatchesURL(api.get(), "storage", "https://blah.net"));
   EXPECT_FALSE(MatchesURL(api.get(), "storage", "file://somefile.html"));
@@ skipping 238 matching lines @@
                                          extension.get(),
                                          Feature::BLESSED_EXTENSION_CONTEXT,
                                          GURL()).is_available());
   EXPECT_FALSE(extension_api->IsAvailable("pageAction",
                                           extension.get(),
                                           Feature::BLESSED_EXTENSION_CONTEXT,
                                           GURL()).is_available());
 }
 
 }  // namespace extensions