Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: RPH observer DCHECK and browser tests build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index d729d3efcac7b94145f6929835d3b2aeee5244a1..4645fe1c71cbe3cb1fff1e5ddb9faf5f13f88196 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -122,13 +122,10 @@ class CONTENT_EXPORT ServiceWorkerVersion
void StartWorker(const StatusCallback& callback);
// Starts an embedded worker for this version.
- // |potential_process_ids| is a list of processes in which to start the
- // worker.
+ // |pause_after_download| is a flag to tell worker to pause after download.
Jeffrey Yasskin 2014/08/19 23:42:24 This isn't a particularly useful comment. What wou
xiang 2014/08/29 07:49:40 Done.
// This returns OK (success) if the worker is already running.
- void StartWorkerWithCandidateProcesses(
- const std::vector<int>& potential_process_ids,
- bool pause_after_download,
- const StatusCallback& callback);
+ void StartWorker(bool pause_after_download,
+ const StatusCallback& callback);
// Stops an embedded worker for this version.
// This returns OK (success) if the worker is already stopped.
@@ -203,9 +200,6 @@ class CONTENT_EXPORT ServiceWorkerVersion
void AddProcessToWorker(int process_id);
void RemoveProcessFromWorker(int process_id);
- // Returns true if this has at least one process to run.
- bool HasProcessToRun() const;
-
// Adds and removes |provider_host| as a controllee of this ServiceWorker.
// A potential controllee is a host having the version as its .installing
// or .waiting version.
@@ -214,6 +208,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
void AddPotentialControllee(ServiceWorkerProviderHost* provider_host);
void RemovePotentialControllee(ServiceWorkerProviderHost* provider_host);
+ // Notifies process manager about the callback pending renderer processes.
+ void AddPendingProcesses(const std::vector<int>& pending_processes);
+
// Returns if it has controllee.
bool HasControllee() const { return !controllee_map_.empty(); }

Powered by Google App Engine
This is Rietveld 408576698