Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: RPH observer DCHECK and browser tests build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_register_job.cc
diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc
index 87e5ebb087e56729c97209876b16a135dc1325b7..90f951ba235e5f6aab03d80dde6dff8e153fc3a4 100644
--- a/content/browser/service_worker/service_worker_register_job.cc
+++ b/content/browser/service_worker/service_worker_register_job.cc
@@ -190,6 +190,9 @@ void ServiceWorkerRegisterJob::ContinueWithRegistration(
UpdateAndContinue();
return;
}
+
+ existing_registration->active_version()->AddPendingProcesses(
+ pending_process_ids_);
ResolvePromise(
status, existing_registration, existing_registration->active_version());
Complete(SERVICE_WORKER_OK);
@@ -266,11 +269,11 @@ void ServiceWorkerRegisterJob::UpdateAndContinue() {
set_new_version(new ServiceWorkerVersion(
registration(), context_->storage()->NewVersionId(), context_));
+ new_version()->AddPendingProcesses(pending_process_ids_);
bool pause_after_download = job_type_ == UPDATE_JOB;
if (pause_after_download)
new_version()->embedded_worker()->AddListener(this);
- new_version()->StartWorkerWithCandidateProcesses(
- pending_process_ids_,
+ new_version()->StartWorker(
pause_after_download,
base::Bind(&ServiceWorkerRegisterJob::OnStartWorkerFinished,
weak_factory_.GetWeakPtr()));

Powered by Google App Engine
This is Rietveld 408576698