Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: RPH observer DCHECK and browser tests build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 6986d5e03126fe0f5c9000eba24cabc52f3de661..9957157b5a085603ce7472fdf2e501644095b7f4 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -210,9 +210,9 @@ class ServiceWorkerBrowserTest : public ContentBrowserTest {
ServiceWorkerContextWrapper* wrapper() { return wrapper_.get(); }
ServiceWorkerContext* public_context() { return wrapper(); }
- void AssociateRendererProcessToWorker(EmbeddedWorkerInstance* worker) {
- worker->AddProcessReference(
- shell()->web_contents()->GetRenderProcessHost()->GetID());
+ void AssociateRendererProcessToScope(const GURL& scope) {
+ wrapper_->process_manager()->AddScopeProcessReference(
+ scope, shell()->web_contents()->GetRenderProcessHost()->GetID());
}
private:
@@ -242,21 +242,21 @@ class EmbeddedWorkerBrowserTest : public ServiceWorkerBrowserTest,
EXPECT_EQ(EmbeddedWorkerInstance::STOPPED, worker_->status());
worker_->AddListener(this);
- AssociateRendererProcessToWorker(worker_.get());
const int64 service_worker_version_id = 33L;
const GURL scope = embedded_test_server()->GetURL("/");
const GURL script_url = embedded_test_server()->GetURL(
"/service_worker/worker.js");
+ AssociateRendererProcessToScope(scope);
std::vector<int> processes;
processes.push_back(
shell()->web_contents()->GetRenderProcessHost()->GetID());
+ wrapper()->process_manager()->AddScopePendingProcesses(scope, processes);
worker_->Start(
service_worker_version_id,
scope,
script_url,
pause_mode_ != DONT_PAUSE,
- processes,
base::Bind(&EmbeddedWorkerBrowserTest::StartOnIOThread2, this));
}
void StartOnIOThread2(ServiceWorkerStatusCode status) {
@@ -417,8 +417,9 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
}
void SetUpRegistrationOnIOThread(const std::string& worker_url) {
+ const GURL scope = embedded_test_server()->GetURL("/");
registration_ = new ServiceWorkerRegistration(
- embedded_test_server()->GetURL("/"),
+ scope,
embedded_test_server()->GetURL(worker_url),
wrapper()->context()->storage()->NewRegistrationId(),
wrapper()->context()->AsWeakPtr());
@@ -426,7 +427,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
registration_,
wrapper()->context()->storage()->NewVersionId(),
wrapper()->context()->AsWeakPtr());
- AssociateRendererProcessToWorker(version_->embedded_worker());
+ AssociateRendererProcessToScope(scope);
}
void StartOnIOThread(const base::Closure& done,

Powered by Google App Engine
This is Rietveld 408576698