content/browser/service_worker/embedded_worker_test_helper.cc - Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: RPH observer DCHECK and browser tests build fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_test_helper.h ('k') | content/browser/service_worker/service_worker_browsertest.cc » ('j') | content/browser/service_worker/service_worker_process_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_test_helper.cc

diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc

index e607bc08a2f129e3ee24fd8e44a94fc17d289201..02fc19797b023556f37a1900bb84726d1e796364 100644

--- a/content/browser/service_worker/embedded_worker_test_helper.cc

+++ b/content/browser/service_worker/embedded_worker_test_helper.cc

@@ -37,13 +37,11 @@ EmbeddedWorkerTestHelper::~EmbeddedWorkerTestHelper() {

wrapper_->Shutdown();

}

-void EmbeddedWorkerTestHelper::SimulateAddProcessToWorker(

- int embedded_worker_id,

+void EmbeddedWorkerTestHelper::SimulateAddProcessToScope(

+ const GURL& scope,

int process_id) {

- EmbeddedWorkerInstance* worker = registry()->GetWorker(embedded_worker_id);

- ASSERT_TRUE(worker);

registry()->AddChildProcessSender(process_id, this);

- worker->AddProcessReference(process_id);

+ wrapper_->process_manager()->AddScopeProcessReference(scope, process_id);

}

bool EmbeddedWorkerTestHelper::Send(IPC::Message* message) {