Typecheck chrome://help using CompilerPass.java, everything except dependency to options

Typecheck chrome://help using CompilerPass.java, everything except dependency to options and Element.prototype.contains(Node)

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/help/compiled_resources.gyp && ninja -C out/Default

Committed: https://crrev.com/2ee4e3d7fa891c4aee1b3462f7caa0f5cde07c72
Cr-Commit-Position: refs/heads/master@{#293645}

[Dan Beam, 2014-08-05 18:49:27]

https://codereview.chromium.org/443553002/diff/1/chrome/browser/resources/hel...
File chrome/browser/resources/help/help_base_page.js (right):

https://codereview.chromium.org/443553002/diff/1/chrome/browser/resources/hel...
chrome/browser/resources/help/help_base_page.js:204: return /** @type
{HTMLDivElement} */(this.pageDiv.parentNode);
why don't you make this HTMLElement instead?  Div is pretty specific and offers
no benefits, afaik.

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr.js
File ui/webui/resources/js/cr.js (right):

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr.js#...
ui/webui/resources/js/cr.js:301: exportPath: exportPath,
^ still needed?

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/bubble.js:53: };
^ is this still needed?

[Vitaly Pavlenko, 2014-08-05 23:00:54]

https://codereview.chromium.org/443553002/diff/1/chrome/browser/resources/hel...
File chrome/browser/resources/help/help_base_page.js (right):

https://codereview.chromium.org/443553002/diff/1/chrome/browser/resources/hel...
chrome/browser/resources/help/help_base_page.js:204: return /** @type
{HTMLDivElement} */(this.pageDiv.parentNode);
On 2014/08/05 18:49:27, Dan Beam wrote:
> why don't you make this HTMLElement instead?  Div is pretty specific and
offers
> no benefits, afaik.

Done.

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr.js
File ui/webui/resources/js/cr.js (right):

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr.js#...
ui/webui/resources/js/cr.js:301: exportPath: exportPath,
On 2014/08/05 18:49:27, Dan Beam wrote:
> ^ still needed?

it's used in ui/webui/resources/js/cr/ui/bubble.js:7 as described in my answer
below (or above)

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/bubble.js:53: };
On 2014/08/05 18:49:27, Dan Beam wrote:
> ^ is this still needed?

Yes. If I move these declarations inside scope function body, then I'll get the
Closure Compiler problem that one can't declare a @enum non-globally.

Reproducer:

function f() {
  /** @enum */ window.MyEnum = {a: 1, b: 2};
}

/** @type {window.MyEnum} */
var Var = window.MyEnum.a;

// JSC_TYPE_PARSE_ERROR: Bad type annotation. Unknown type window.MyEnum at line
5 character 11
// /** @type {window.MyEnum} */
//            ^

After Chrome pass the code inside scope function body still remains inside scope
function body.

[Dan Beam, 2014-08-05 23:09:29]

lgtm

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/bubble.js:53: };
On 2014/08/05 23:00:54, Vitaly Pavlenko wrote:
> On 2014/08/05 18:49:27, Dan Beam wrote:
> > ^ is this still needed?
> 
> Yes. If I move these declarations inside scope function body, then I'll get
the
> Closure Compiler problem that one can't declare a @enum non-globally.
> 
> Reproducer:
> 
> function f() {
>   /** @enum */ window.MyEnum = {a: 1, b: 2};
> }
> 
> /** @type {window.MyEnum} */
> var Var = window.MyEnum.a;
> 
> // JSC_TYPE_PARSE_ERROR: Bad type annotation. Unknown type window.MyEnum at
line
> 5 character 11
> // /** @type {window.MyEnum} */
> //            ^
> 
> After Chrome pass the code inside scope function body still remains inside
scope
> function body.

ok, is there a github issue you can reference (assuming we want local enums to
be exportable)?

[Vitaly Pavlenko, 2014-08-06 00:16:42]

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/bubble.js:53: };
On 2014/08/05 23:09:29, Dan Beam wrote:
> On 2014/08/05 23:00:54, Vitaly Pavlenko wrote:
> > On 2014/08/05 18:49:27, Dan Beam wrote:
> > > ^ is this still needed?
> > 
> > Yes. If I move these declarations inside scope function body, then I'll get
> the
> > Closure Compiler problem that one can't declare a @enum non-globally.
> > 
> > Reproducer:
> > 
> > function f() {
> >   /** @enum */ window.MyEnum = {a: 1, b: 2};
> > }
> > 
> > /** @type {window.MyEnum} */
> > var Var = window.MyEnum.a;
> > 
> > // JSC_TYPE_PARSE_ERROR: Bad type annotation. Unknown type window.MyEnum at
> line
> > 5 character 11
> > // /** @type {window.MyEnum} */
> > //            ^
> > 
> > After Chrome pass the code inside scope function body still remains inside
> scope
> > function body.
> 
> ok, is there a github issue you can reference (assuming we want local enums to
> be exportable)?

Done.

[Vitaly Pavlenko, 2014-08-12 20:25:25]

I rebased these fixes onto master. In the meantime HelpPage was changed, so I
have some more fixes. Please, review this CL once again.

I've added assert.js to this CL, the same changes are now in
https://codereview.chromium.org/454223004/ . I'd like to commit assert.js with
the fastest CL which I succeed to commit.

[Dan Beam, 2014-08-13 22:20:08]

https://chromiumcodereview.appspot.com/443553002/diff/60001/chrome/browser/re...
File chrome/browser/resources/help/help_page.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/chrome/browser/re...
chrome/browser/resources/help/help_page.js:165: * @param {function()} method The
click handler.
nit: Function instead

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/assert.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/assert.js:58: if (!(value instanceof type)) {
nit: no curlies

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/assert.js:59: throw new Error('assertInstanceof');
throw new Error(value + ' is not a[n] ' + (type.name || typeof type));

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:480: if (event.button == 0 &&
this.anchorNode_.contains(event.target))
why don't you have to use assertInstanceOf here?

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:485: if
(this.contains(assertInstanceof(event.target, Element)))
nit: Node instead of Element

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/page_manager/page.js (left):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page.js:18: * @extends {EventTarget}
this needs to match with the __proto__ line

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/page_manager/page_manager.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page_manager.js:79: * @param
{cr.ui.pageManager.Page} page Page to register.
seems like this probably ought to be !cr.ui.pageManager.Page instead, right?

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page_manager.js:89: * @param
{cr.ui.pageManager.Page} parentPage Associated parent page for
^ and here as well (with the !)

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page_manager.js:466: * @param
{cr.ui.pageManager.PageManager.Observer} observer The observer to
nit: !

[Vitaly Pavlenko, 2014-08-14 00:01:03]

https://chromiumcodereview.appspot.com/443553002/diff/60001/chrome/browser/re...
File chrome/browser/resources/help/help_page.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/chrome/browser/re...
chrome/browser/resources/help/help_page.js:165: * @param {function()} method The
click handler.
On 2014/08/13 22:20:07, Dan Beam wrote:
> nit: Function instead

Done.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/assert.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/assert.js:58: if (!(value instanceof type)) {
On 2014/08/13 22:20:08, Dan Beam wrote:
> nit: no curlies

Done.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/assert.js:59: throw new Error('assertInstanceof');
On 2014/08/13 22:20:07, Dan Beam wrote:
> throw new Error(value + ' is not a[n] ' + (type.name || typeof type));

Done.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:480: if (event.button == 0 &&
this.anchorNode_.contains(event.target))
On 2014/08/13 22:20:08, Dan Beam wrote:
> why don't you have to use assertInstanceOf here?

At that point compiler doesn't know what type has this.anchorNode_ and can't
guess which arguments should this.anchorNode_.contains() receive.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:485: if
(this.contains(assertInstanceof(event.target, Element)))
On 2014/08/13 22:20:08, Dan Beam wrote:
> nit: Node instead of Element

Done.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/page_manager/page.js (left):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page.js:18: * @extends {EventTarget}
On 2014/08/13 22:20:08, Dan Beam wrote:
> this needs to match with the __proto__ line

Done.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/page_manager/page_manager.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page_manager.js:79: * @param
{cr.ui.pageManager.Page} page Page to register.
On 2014/08/13 22:20:08, Dan Beam wrote:
> seems like this probably ought to be !cr.ui.pageManager.Page instead, right?

Done.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page_manager.js:89: * @param
{cr.ui.pageManager.Page} parentPage Associated parent page for
On 2014/08/13 22:20:08, Dan Beam wrote:
> ^ and here as well (with the !)

Only for overlay. For parentPage there are checks for being true when it's used.

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/page_manager/page_manager.js:466: * @param
{cr.ui.pageManager.PageManager.Observer} observer The observer to
On 2014/08/13 22:20:08, Dan Beam wrote:
> nit: !

Done.

[Dan Beam, 2014-08-14 00:47:02]

lgtm

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/60001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:480: if (event.button == 0 &&
this.anchorNode_.contains(event.target))
On 2014/08/14 00:01:02, Vitaly Pavlenko wrote:
> On 2014/08/13 22:20:08, Dan Beam wrote:
> > why don't you have to use assertInstanceOf here?
> 
> At that point compiler doesn't know what type has this.anchorNode_ and can't
> guess which arguments should this.anchorNode_.contains() receive.

please add anchorNode_ to the prototype

[Dan Beam, 2014-08-14 00:47:51]

https://chromiumcodereview.appspot.com/443553002/diff/80001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/80001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:486: if
(this.contains(assertInstanceof(event.target, Element)))
not lgtm, not done

[Vitaly Pavlenko, 2014-08-18 21:21:14]

https://chromiumcodereview.appspot.com/443553002/diff/80001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/80001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:486: if
(this.contains(assertInstanceof(event.target, Element)))
On 2014/08/14 00:47:50, Dan Beam wrote:
> not lgtm, not done

I asked the compiler team for helping me with externs:
https://github.com/google/closure-compiler/issues/470#issuecomment-52219387

As tbreisacher@ told me, there's no simple way to fix that problem with open
source tools. One possible way involves opening up the jar and modifying it, but
it's not a good idea.

[Dan Beam, 2014-08-19 03:09:21]

https://chromiumcodereview.appspot.com/443553002/diff/80001/ui/webui/resource...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/80001/ui/webui/resource...
ui/webui/resources/js/cr/ui/bubble.js:483: // Close the bubble when the
underlying document is scrolled.
^ this would imply the assertInstanceOf() will fail

[Vitaly Pavlenko, 2014-08-27 21:36:03]

https://codereview.chromium.org/443553002/diff/80001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/80001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/bubble.js:486: if
(this.contains(assertInstanceof(event.target, Element)))
On 2014/08/18 21:21:13, Vitaly Pavlenko wrote:
> On 2014/08/14 00:47:50, Dan Beam wrote:
> > not lgtm, not done
> 
> I asked the compiler team for helping me with externs:
> https://github.com/google/closure-compiler/issues/470#issuecomment-52219387
> 
> As tbreisacher@ told me, there's no simple way to fix that problem with open
> source tools. One possible way involves opening up the jar and modifying it,
but
> it's not a good idea.

Can't reproduce the case when this.contains() doesn't work. Works now for me.

[Dan Beam, 2014-08-27 21:42:01]

https://codereview.chromium.org/443553002/diff/80001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/80001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/bubble.js:486: if
(this.contains(assertInstanceof(event.target, Element)))
On 2014/08/27 21:36:03, Vitaly Pavlenko wrote:
> On 2014/08/18 21:21:13, Vitaly Pavlenko wrote:
> > On 2014/08/14 00:47:50, Dan Beam wrote:
> > > not lgtm, not done
> > 
> > I asked the compiler team for helping me with externs:
> > https://github.com/google/closure-compiler/issues/470#issuecomment-52219387
> > 
> > As tbreisacher@ told me, there's no simple way to fix that problem with open
> > source tools. One possible way involves opening up the jar and modifying it,
> but
> > it's not a good idea.
> 
> Can't reproduce the case when this.contains() doesn't work. Works now for me.

you mean even with assertInstanceOf(event.target, Node)?

[Vitaly Pavlenko, 2014-08-27 21:59:51]

On 2014/08/27 21:42:01, Dan Beam wrote:
>
https://codereview.chromium.org/443553002/diff/80001/ui/webui/resources/js/cr...
> File ui/webui/resources/js/cr/ui/bubble.js (right):
> 
>
https://codereview.chromium.org/443553002/diff/80001/ui/webui/resources/js/cr...
> ui/webui/resources/js/cr/ui/bubble.js:486: if
> (this.contains(assertInstanceof(event.target, Element)))
> On 2014/08/27 21:36:03, Vitaly Pavlenko wrote:
> > On 2014/08/18 21:21:13, Vitaly Pavlenko wrote:
> > > On 2014/08/14 00:47:50, Dan Beam wrote:
> > > > not lgtm, not done
> > > 
> > > I asked the compiler team for helping me with externs:
> > >
https://github.com/google/closure-compiler/issues/470#issuecomment-52219387
> > > 
> > > As tbreisacher@ told me, there's no simple way to fix that problem with
open
> > > source tools. One possible way involves opening up the jar and modifying
it,
> > but
> > > it's not a good idea.
> > 
> > Can't reproduce the case when this.contains() doesn't work. Works now for
me.
> 
> you mean even with assertInstanceOf(event.target, Node)?

Sorry, I forgot to remove @suppress {checkTypes}. Reproduced now.

[Dan Beam, 2014-08-27 23:38:38]

very very close

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:488: case 'mousedown':
assertInstanceOf(event.target, Node);

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:489: if (event.button == 0 && event.target
&&
remove event.target &&

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:490:
this.anchorNode.contains(assertInstanceof(event.target, Node)))
curlies

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:494: case 'scroll':
assertInstanceOf(event.target, Node);

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:496:
this.contains(assertInstanceof(event.target, Node)))
curlies

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:499: case 'resize':
assert(event.target == window);

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:504: case 'elementFocused':
assertInstanceOf(event.target, Node);

[Vitaly Pavlenko, 2014-08-28 18:19:49]

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:488: case 'mousedown':
On 2014/08/27 23:38:37, Dan Beam wrote:
> assertInstanceOf(event.target, Node);

Done, but inlined, because otherwise compiler don't understand type at the point
of usage.

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:489: if (event.button == 0 && event.target
&&
On 2014/08/27 23:38:37, Dan Beam wrote:
> remove event.target &&

Done.

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:490:
this.anchorNode.contains(assertInstanceof(event.target, Node)))
On 2014/08/27 23:38:38, Dan Beam wrote:
> curlies

Done.

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:494: case 'scroll':
On 2014/08/27 23:38:37, Dan Beam wrote:
> assertInstanceOf(event.target, Node);

Done.

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:496:
this.contains(assertInstanceof(event.target, Node)))
On 2014/08/27 23:38:38, Dan Beam wrote:
> curlies

Don't need anymore.

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:499: case 'resize':
On 2014/08/27 23:38:37, Dan Beam wrote:
> assert(event.target == window);

Done.

https://chromiumcodereview.appspot.com/443553002/diff/160001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:504: case 'elementFocused':
On 2014/08/27 23:38:37, Dan Beam wrote:
> assertInstanceOf(event.target, Node);

Done.

[Dan Beam, 2014-09-06 02:27:19]

lgtm w/nit

https://chromiumcodereview.appspot.com/443553002/diff/180001/ui/webui/resourc...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://chromiumcodereview.appspot.com/443553002/diff/180001/ui/webui/resourc...
ui/webui/resources/js/cr/ui/bubble.js:505: case 'elementFocused':
var target = assertInstanceof(event.target, Node);
if (!this.anchorNode_.contains(target) && !this.contains(target)) {

[Vitaly Pavlenko, 2014-09-06 23:13:05]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-06 23:13:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalyp@chromium.org/443553002/200001

[commit-bot: I haz the power, 2014-09-07 00:12:10]

Committed patchset #11 (id:200001) as 8e07f620d8c0a589832a9c62b28e46eda06b24aa

[commit-bot: I haz the power, 2014-09-10 03:43:41]

Patchset 11 (id:??) landed as
https://crrev.com/2ee4e3d7fa891c4aee1b3462f7caa0f5cde07c72
Cr-Commit-Position: refs/heads/master@{#293645}

[Dan Beam, 2014-09-17 16:31:27]

https://codereview.chromium.org/443553002/diff/200001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/443553002/diff/200001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/bubble.js:172: var anchor =
this.anchorNode.getBoundingClientRect();
the breakage

https://codereview.chromium.org/443553002/diff/200001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/bubble.js:490:
this.anchorNode.contains(assertInstanceof(event.target, Node))) {
breakage

https://codereview.chromium.org/443553002/diff/200001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/bubble.js:500: assert(event.target == window);
also wrong :(