Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: ui/webui/resources/js/cr/ui/page_manager/page_manager.js

Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: fixed one nit Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/cr/ui/page_manager/page_manager.js
diff --git a/ui/webui/resources/js/cr/ui/page_manager/page_manager.js b/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
index 0c0c92a189fee3277d24f42bde8c7cfa46d1bb93..556ec8765e7aaa3a3f95413086703c80056068da 100644
--- a/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
+++ b/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
@@ -44,7 +44,7 @@ cr.define('cr.ui.pageManager', function() {
/**
* Observers will be notified when opening and closing overlays.
- * @type {!Array.<!PageManager.Observer>}
+ * @type {!Array.<!cr.ui.pageManager.PageManager.Observer>}
*/
observers_: [],
@@ -76,7 +76,7 @@ cr.define('cr.ui.pageManager', function() {
/**
* Registers new page.
- * @param {cr.ui.page_manager.Page} page Page to register.
+ * @param {!cr.ui.pageManager.Page} page Page to register.
*/
register: function(page) {
this.registeredPages[page.name.toLowerCase()] = page;
@@ -85,8 +85,8 @@ cr.define('cr.ui.pageManager', function() {
/**
* Registers a new Overlay page.
- * @param {cr.ui.page_manager.Page} overlay Overlay to register.
- * @param {cr.ui.page_manager.Page} parentPage Associated parent page for
+ * @param {!cr.ui.pageManager.Page} overlay Overlay to register.
+ * @param {cr.ui.pageManager.Page} parentPage Associated parent page for
* this overlay.
* @param {Array} associatedControls Array of control elements associated
* with this page.
@@ -381,7 +381,7 @@ cr.define('cr.ui.pageManager', function() {
/**
* Returns the currently visible bubble, or null if no bubble is visible.
- * @return {AutoCloseBubble} The bubble currently being shown.
+ * @return {cr.ui.AutoCloseBubble} The bubble currently being shown.
*/
getVisibleBubble: function() {
var bubble = this.bubble_;
@@ -444,7 +444,8 @@ cr.define('cr.ui.pageManager', function() {
},
/**
- * @param {PageManager.Observer} observer The observer to register.
+ * @param {!cr.ui.pageManager.PageManager.Observer} observer The observer to
+ * register.
*/
addObserver: function(observer) {
this.observers_.push(observer);
@@ -583,7 +584,7 @@ cr.define('cr.ui.pageManager', function() {
* to update the history.
* @param {boolean} replace If true, handlers should replace the current
* history event rather than create new ones.
- * @param {object=} opt_params A bag of optional params, including:
+ * @param {Object=} opt_params A bag of optional params, including:
* {boolean} ignoreHash Whether to include the hash or not.
* @private
*/
@@ -623,8 +624,8 @@ cr.define('cr.ui.pageManager', function() {
/**
* Find an enclosing section for an element if it exists.
- * @param {Element} element Element to search.
- * @return {Element} The section element, or null.
+ * @param {Node} node Element to search.
+ * @return {Node} The section element, or null.
* @private
*/
findSectionForNode_: function(node) {

Powered by Google App Engine
This is Rietveld 408576698