Use a C++11 feature in a single file, to discover if this works everywhere.

Use a C++11 feature in a single file, to discover if this works everywhere.

Similar to https://codereview.chromium.org/385743002 , but in a file
that's also built in host targets. Depends on r#294584.

If your bot can't deal with this, please let me know!

BUG=none

Committed: https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593
Cr-Commit-Position: refs/heads/master@{#294687}

R=ajwong@chromium.org

Committed: https://crrev.com/3249a55da6e8331b70938a86e27359d432908608
Cr-Commit-Position: refs/heads/master@{#294961}

[Nico, 2014-09-12 16:00:43]

thakis@chromium.org changed reviewers:
+ ajwong@chromium.org

[awong, 2014-09-12 18:11:57]

On 2014/09/12 16:00:44, Nico (hiding) wrote:

LGTM

[Nico, 2014-09-12 21:40:04]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-09-12 21:42:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/443483002/70001

[commit-bot: I haz the power, 2014-09-12 22:56:45]

Committed patchset #5 (id:70001) as a77e283ac247d15bcd86a3ef708ae3a6e422d4eb

[commit-bot: I haz the power, 2014-09-12 23:01:34]

Patchset 5 (id:??) landed as
https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593
Cr-Commit-Position: refs/heads/master@{#294687}

[kevers, 2014-09-15 14:32:01]

A revert of this CL (patchset #5 id:70001) has been created in
https://codereview.chromium.org/570083002/ by kevers@chromium.org.

The reason for reverting is: Breaks Arm compile of Chrome on ChromeOS.

http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%...

chromeos-chrome-39.0.2157.0_alpha-r1: In file included from
threading/watchdog.cc:5:0:
chromeos-chrome-39.0.2157.0_alpha-r1: ../base/threading/watchdog.h:68:29: error:
override controls (override/final) only available with -std=c++11 or
-std=gnu++11 [-Werror]
chromeos-chrome-39.0.2157.0_alpha-r1:      virtual void ThreadMain() OVERRIDE;



.

[Nico, 2014-09-15 16:15:26]

On 2014/09/15 14:32:01, kevers wrote:
> A revert of this CL (patchset #5 id:70001) has been created in
> https://codereview.chromium.org/570083002/ by mailto:kevers@chromium.org.
> 
> The reason for reverting is: Breaks Arm compile of Chrome on ChromeOS.
> 
>
http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%...
> 
> chromeos-chrome-39.0.2157.0_alpha-r1: In file included from
> threading/watchdog.cc:5:0:
> chromeos-chrome-39.0.2157.0_alpha-r1: ../base/threading/watchdog.h:68:29:
error:
> override controls (override/final) only available with -std=c++11 or
> -std=gnu++11 [-Werror]
> chromeos-chrome-39.0.2157.0_alpha-r1:      virtual void ThreadMain() OVERRIDE;

(in this case, it'd've been interesting to include the command line as well,
since this only seems to be happening for nacl compiles, not for regular
compiles)

[Nico, 2014-09-16 01:25:33]

On 2014/09/15 16:15:26, Nico (hiding) wrote:
> On 2014/09/15 14:32:01, kevers wrote:
> > A revert of this CL (patchset #5 id:70001) has been created in
> > https://codereview.chromium.org/570083002/ by mailto:kevers@chromium.org.
> > 
> > The reason for reverting is: Breaks Arm compile of Chrome on ChromeOS.
> > 
> >
>
http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%...
> > 
> > chromeos-chrome-39.0.2157.0_alpha-r1: In file included from
> > threading/watchdog.cc:5:0:
> > chromeos-chrome-39.0.2157.0_alpha-r1: ../base/threading/watchdog.h:68:29:
> error:
> > override controls (override/final) only available with -std=c++11 or
> > -std=gnu++11 [-Werror]
> > chromeos-chrome-39.0.2157.0_alpha-r1:      virtual void ThreadMain()
OVERRIDE;
> 
> (in this case, it'd've been interesting to include the command line as well,
> since this only seems to be happening for nacl compiles, not for regular
> compiles)

I think https://codereview.chromium.org/571143002/ fixed this problem, so I'm
relanding this.

[Nico, 2014-09-16 01:28:49]

Committed patchset #5 (id:70001) to pending queue manually as d1dd454.

[commit-bot: I haz the power, 2014-09-16 01:30:52]

Patchset 5 (id:??) landed as
https://crrev.com/3249a55da6e8331b70938a86e27359d432908608
Cr-Commit-Position: refs/heads/master@{#294961}