Chromium Code Reviews| Index: ui/android/java/res/layout/dropdown_item.xml |
| diff --git a/ui/android/java/res/layout/dropdown_item.xml b/ui/android/java/res/layout/dropdown_item.xml |
| index bded0ad992682189db918912a3dfb442a160eaaa..85cf407da23863951e0bf4f41f9109fc7d1c4649 100644 |
| --- a/ui/android/java/res/layout/dropdown_item.xml |
| +++ b/ui/android/java/res/layout/dropdown_item.xml |
| @@ -6,29 +6,43 @@ |
| --> |
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| - android:id="@+id/dropdown_menu_text" |
| - android:orientation="vertical" |
| + android:orientation="horizontal" |
| + android:layout_width="match_parent" |
| + android:layout_height="wrap_content" |
| android:gravity="center_vertical"> |
| - <TextView android:id="@+id/dropdown_label" |
| + <LinearLayout |
| + android:layout_weight="1" |
| android:layout_width="wrap_content" |
|
aurimas (slooooooooow)
2014/11/04 23:04:22
You want to change the width to 0dp since you have
Evan Stade
2014/11/04 23:09:52
Wouldn't leaving layout_width at wrap_content effe
|
| android:layout_height="wrap_content" |
| - android:layout_marginStart="10dp" |
| - android:layout_marginEnd="10dp" |
| - android:ellipsize="end" |
| - android:singleLine="true" |
| - android:textAlignment="viewStart" |
| - android:textSize="18sp" |
| - android:includeFontPadding="false"/> |
| - <TextView android:id="@+id/dropdown_sublabel" |
| + android:orientation="vertical"> |
| + |
| + <TextView android:id="@+id/dropdown_label" |
| + android:layout_width="wrap_content" |
| + android:layout_height="wrap_content" |
| + android:layout_marginStart="10dp" |
| + android:layout_marginEnd="10dp" |
| + android:ellipsize="end" |
| + android:singleLine="true" |
| + android:textAlignment="viewStart" |
| + android:textSize="18sp" |
| + android:includeFontPadding="false"/> |
| + <TextView android:id="@+id/dropdown_sublabel" |
| + android:layout_width="wrap_content" |
| + android:layout_height="wrap_content" |
| + android:layout_marginStart="10dp" |
| + android:layout_marginEnd="10dp" |
| + android:textSize="14sp" |
| + android:textColor="#8b8b8b" |
| + android:ellipsize="end" |
| + android:singleLine="true" |
| + android:textAlignment="viewStart" |
| + android:includeFontPadding="false"/> |
| + </LinearLayout> |
| + |
| + <ImageView android:id="@+id/dropdown_icon" |
| android:layout_width="wrap_content" |
| android:layout_height="wrap_content" |
| - android:layout_marginStart="10dp" |
| - android:layout_marginEnd="10dp" |
| - android:textSize="14sp" |
| - android:textColor="#8b8b8b" |
| - android:ellipsize="end" |
| - android:singleLine="true" |
| - android:textAlignment="viewStart" |
| - android:includeFontPadding="false"/> |
| + android:layout_margin="8dp"/> |
| + |
| </LinearLayout> |