ui/android/java/res/layout/dropdown_item.xml - Issue 443193006: Show icons in Android web autofill dropdown

Side by Side Diff: ui/android/java/res/layout/dropdown_item.xml

Issue 443193006: Show icons in Android web autofill dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: aurimas review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java ('k') | ui/android/java/src/org/chromium/ui/DropdownAdapter.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

9 android:id="@+id/dropdown_menu_text"	9 android:orientation="horizontal"

10 android:orientation="vertical"	10 android:layout_width="match_parent"

	11 android:layout_height="wrap_content"

11 android:gravity="center_vertical">	12 android:gravity="center_vertical">

12	13

13 <TextView android:id="@+id/dropdown_label"	14 <LinearLayout

	15 android:layout_weight="1"

14 android:layout_width="wrap_content"	16 android:layout_width="wrap_content"
	aurimas (slooooooooow) 2014/11/04 23:04:22 You want to change the width to 0dp since you have You want to change the width to 0dp since you have weight for it. Evan Stade 2014/11/04 23:09:52 Wouldn't leaving layout_width at wrap_content effe Show quoted text On 2014/11/04 23:04:22, aurimas wrote: > You want to change the width to 0dp since you have weight for it. Wouldn't leaving layout_width at wrap_content effectively create a minimum width (which in this case would be good)? I'm having trouble finding detailed docs but I thought layout_weight only applied to how to divide leftover space.
15 android:layout_height="wrap_content"	17 android:layout_height="wrap_content"

16 android:layout_marginStart="10dp"	18 android:orientation="vertical">

17 android:layout_marginEnd="10dp"	19

18 android:ellipsize="end"	20 <TextView android:id="@+id/dropdown_label"

19 android:singleLine="true"	21 android:layout_width="wrap_content"

20 android:textAlignment="viewStart"	22 android:layout_height="wrap_content"

21 android:textSize="18sp"	23 android:layout_marginStart="10dp"

22 android:includeFontPadding="false"/>	24 android:layout_marginEnd="10dp"

23 <TextView android:id="@+id/dropdown_sublabel"	25 android:ellipsize="end"

	26 android:singleLine="true"

	27 android:textAlignment="viewStart"

	28 android:textSize="18sp"

	29 android:includeFontPadding="false"/>

	30 <TextView android:id="@+id/dropdown_sublabel"

	31 android:layout_width="wrap_content"

	32 android:layout_height="wrap_content"

	33 android:layout_marginStart="10dp"

	34 android:layout_marginEnd="10dp"

	35 android:textSize="14sp"

	36 android:textColor="#8b8b8b"

	37 android:ellipsize="end"

	38 android:singleLine="true"

	39 android:textAlignment="viewStart"

	40 android:includeFontPadding="false"/>

	41 </LinearLayout>

	42

	43 <ImageView android:id="@+id/dropdown_icon"

24 android:layout_width="wrap_content"	44 android:layout_width="wrap_content"

25 android:layout_height="wrap_content"	45 android:layout_height="wrap_content"

26 android:layout_marginStart="10dp"	46 android:layout_margin="8dp"/>

27 android:layout_marginEnd="10dp"	47

28 android:textSize="14sp"

29 android:textColor="#8b8b8b"

30 android:ellipsize="end"

31 android:singleLine="true"

32 android:textAlignment="viewStart"

33 android:includeFontPadding="false"/>

34 </LinearLayout>	48 </LinearLayout>

OLD	NEW