Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 443123003: Unified invalidation for repaint-only style changes (non-layers) (Closed)

Created:
6 years, 4 months ago by Xianzhu
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Unified invalidation for repaint-only style changes (non-layers) Use setShouldDoFullPaintInvalidation() for repaint-only style change to avoid paintInvalidationForWholeRenderer() on repaint-only style change. BUG=394004 TEST=existing layout tests. Some previous duplicated repaints combined. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179857

Patch Set 1 : #

Patch Set 2 : For landing #

Patch Set 3 : More rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -23 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
M LayoutTests/svg/filters/filter-refresh-expected.txt View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 2 chunks +3 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Xianzhu
6 years, 4 months ago (2014-08-08 00:13:16 UTC) #1
leviw_travelin_and_unemployed
This is great! Look at all those duplicated invalidations going away :) LGTM.
6 years, 4 months ago (2014-08-08 00:21:06 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-08 00:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/443123003/60001
6 years, 4 months ago (2014-08-08 00:47:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-08 02:14:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 02:40:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/19649)
6 years, 4 months ago (2014-08-08 02:40:24 UTC) #7
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-08 17:23:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/443123003/80001
6 years, 4 months ago (2014-08-08 17:24:01 UTC) #9
Xianzhu
The CQ bit was unchecked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-08 18:08:00 UTC) #10
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-08 18:08:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/443123003/80001
6 years, 4 months ago (2014-08-08 18:09:25 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 19:14:19 UTC) #13
Message was sent while issue was closed.
Change committed as 179857

Powered by Google App Engine
This is Rietveld 408576698