Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 443063003: Revert 287680 "mojo: terminate apps if the shell goes away" (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 287680 "mojo: terminate apps if the shell goes away" These tests started consistently failing: ConnectBasicNetwork, ConnectInvalidServiceNetwork. (e.g http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12739) > mojo: terminate apps if the shell goes away > > Each application <> shell connection is represented by a ShellImpl instance > on the shell side. This CL makes the Application watch its ShellPtr for pipe > errors so it can Quit() itself if the shell goes away (shell loop destroyed). > > mojo_shell_tests starts using a new method to terminate all shell connections > in this CL, and waits afterward until KeepAlive quits the loop signifying that > all apps are gone. This is done prior to destroying the shell MessageLoop so > that the test ensures apps have all died before the next test. In the future > it would be a test failure if this wasn't a no-op, but we have things in the > shell that don't quit themselves right now. > > The shell itself won't wait around for apps to die (as of this CL), but > ~MessageLoop will still send the message to Application sides that will quit. > > ** NOTE ** This does not require an app build target to explicitly add magic > *.cc files to their sources. It requires selecting an appropriate > mojo_application_{chromium, standalone} library akin to mojo_environment_*. > We can possibly combine these two in the future. > > BUG=394477 > > Review URL: https://codereview.chromium.org/394903005 TBR=tim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -175 lines) Patch
M trunk/src/mojo/mojo.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/mojo/mojo_base.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
M trunk/src/mojo/mojo_examples.gypi View 22 chunks +22 lines, -22 lines 0 comments Download
M trunk/src/mojo/mojo_public.gypi View 2 chunks +1 line, -14 lines 0 comments Download
M trunk/src/mojo/mojo_public_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/mojo_services.gypi View 12 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/mojo/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/public/cpp/application/BUILD.gn View 3 chunks +3 lines, -19 lines 0 comments Download
M trunk/src/mojo/public/cpp/application/DEPS View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/mojo/public/cpp/application/application_impl.h View 3 chunks +1 line, -17 lines 0 comments Download
M trunk/src/mojo/public/cpp/application/lib/application_impl.cc View 2 chunks +4 lines, -20 lines 0 comments Download
D trunk/src/mojo/public/cpp/application/lib/application_impl_chromium.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/mojo/public/cpp/application/lib/application_impl_standalone.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M trunk/src/mojo/service_manager/background_shell_service_loader.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/mojo/service_manager/background_shell_service_loader.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M trunk/src/mojo/service_manager/background_shell_service_loader_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M trunk/src/mojo/service_manager/service_manager_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M trunk/src/mojo/services/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/services/network/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/services/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/shell/context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/mojo/shell/context.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M trunk/src/mojo/shell/shell_test_base_unittest.cc View 3 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-06 10:32:04 UTC) #1
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-06 10:32:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287752 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698