Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: trunk/src/mojo/service_manager/background_shell_service_loader_unittest.cc

Issue 443063003: Revert 287680 "mojo: terminate apps if the shell goes away" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/service_manager/background_shell_service_loader_unittest.cc
===================================================================
--- trunk/src/mojo/service_manager/background_shell_service_loader_unittest.cc (revision 287751)
+++ trunk/src/mojo/service_manager/background_shell_service_loader_unittest.cc (working copy)
@@ -52,4 +52,19 @@
loader.LoadService(NULL, GURL(), dummy.handle0.Pass());
}
+// Test that an app that doesn't quit itself can still be handled.
+// TODO(tim): Remove this.
+TEST(BackgroundShellServiceLoaderTest, LoadMisbehavedService) {
+ scoped_ptr<DummyLoader> real_loader(new DummyLoader());
+ real_loader->DontSimulateAppQuit();
+ BackgroundShellServiceLoader loader(
+ real_loader.PassAs<ServiceLoader>(), "test",
+ base::MessageLoop::TYPE_DEFAULT);
+ // Because this app is mis-behaved (doesn't quit itself), we need to
+ // explicitly kill the thread.
+ loader.set_quit_on_shutdown();
+ MessagePipe dummy;
+ loader.LoadService(NULL, GURL(), dummy.handle0.Pass());
+}
+
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698