Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 443043003: Rename components/autocomplete to components/omnibox (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, shishir+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, jam, dominich, tburkard+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, chrome-apps-syd-reviews_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, asvitkine+watch_chromium.org, Jered, davidben+watch_chromium.org, tfarina, donnd+watch_chromium.org, dominich+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su
Project:
chromium
Visibility:
Public.

Description

Rename components/autocomplete to components/omnibox components/omnibox will be the directory to which code under chrome/browser/{autocomplete,omnibox} will move. (https://codereview.chromium.org/415073003#msg7) BUG=371538 TEST=build R=blundell@chromium.org, pkasting@chromium.org TBR=mukai@chromium.org for athena/, sky@chromium.org for include fix under chrome/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288038

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -4027 lines) Patch
M athena/main/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_main.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/main/url_search_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/url_search_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/omnibox/omnibox_prerender.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/keyword_extensions_delegate_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api_testbase.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/scored_history_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/shortcuts_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/shortcuts_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/omnibox_metrics_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/omnibox/omnibox_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_navigation_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/test_with_browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/home_page_overlay_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/startup_pages_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 6 chunks +3 lines, -3 lines 0 comments Download
M components/OWNERS View 2 chunks +3 lines, -3 lines 0 comments Download
D components/autocomplete.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
D components/autocomplete/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D components/autocomplete/DEPS View 1 chunk +0 lines, -15 lines 0 comments Download
D components/autocomplete/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/autocomplete/autocomplete_input.h View 1 chunk +0 lines, -209 lines 0 comments Download
D components/autocomplete/autocomplete_input.cc View 1 chunk +0 lines, -522 lines 0 comments Download
D components/autocomplete/autocomplete_input_unittest.cc View 1 chunk +0 lines, -286 lines 0 comments Download
D components/autocomplete/autocomplete_match.h View 1 chunk +0 lines, -389 lines 0 comments Download
D components/autocomplete/autocomplete_match.cc View 1 chunk +0 lines, -543 lines 0 comments Download
D components/autocomplete/autocomplete_match_type.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/autocomplete/autocomplete_match_type.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D components/autocomplete/autocomplete_match_unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D components/autocomplete/autocomplete_provider.h View 1 chunk +0 lines, -248 lines 0 comments Download
D components/autocomplete/autocomplete_provider.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D components/autocomplete/autocomplete_provider_listener.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/autocomplete/autocomplete_scheme_classifier.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/autocomplete/search_suggestion_parser.h View 1 chunk +0 lines, -291 lines 0 comments Download
D components/autocomplete/search_suggestion_parser.cc View 1 chunk +0 lines, -504 lines 0 comments Download
D components/autocomplete/test_scheme_classifier.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/autocomplete/test_scheme_classifier.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D components/autocomplete/url_prefix.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/autocomplete/url_prefix.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M components/components.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M components/metrics/proto/omnibox_event.proto View 1 chunk +1 line, -1 line 0 comments Download
A components/omnibox.gypi View 1 chunk +60 lines, -0 lines 0 comments Download
A + components/omnibox/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/omnibox/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/omnibox/autocomplete_input.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/autocomplete_input.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/omnibox/autocomplete_input_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/omnibox/autocomplete_match.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/omnibox/autocomplete_match.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/omnibox/autocomplete_match_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/autocomplete_match_type.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/autocomplete_match_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/autocomplete_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/omnibox/autocomplete_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/omnibox/autocomplete_provider_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/autocomplete_scheme_classifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/search_suggestion_parser.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/omnibox/search_suggestion_parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/test_scheme_classifier.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/omnibox/test_scheme_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/url_prefix.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/url_prefix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-06 11:27:28 UTC) #1
hashimoto
6 years, 4 months ago (2014-08-06 11:27:46 UTC) #2
blundell
LGTM Is the plan also to rename all autocomplete_foo files to omnibox_foo?
6 years, 4 months ago (2014-08-06 13:09:22 UTC) #3
Jun Mukai
On 2014/08/06 13:09:22, blundell wrote: > LGTM > > Is the plan also to rename ...
6 years, 4 months ago (2014-08-06 18:07:38 UTC) #4
hashimoto
pkasting@, could you take a look at this change as an owner? On 2014/08/06 18:07:38, ...
6 years, 4 months ago (2014-08-07 03:02:25 UTC) #5
Peter Kasting
RSLGTM
6 years, 4 months ago (2014-08-07 03:30:10 UTC) #6
hashimoto
TBRing sky@chromium.org for include fix under chrome/, mukai@chromium.org for athena/
6 years, 4 months ago (2014-08-07 05:25:11 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-07 05:25:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/443043003/1
6 years, 4 months ago (2014-08-07 05:26:40 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 05:36:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 05:39:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/2294) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/671)
6 years, 4 months ago (2014-08-07 05:39:41 UTC) #12
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-07 06:25:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/443043003/20001
6 years, 4 months ago (2014-08-07 06:26:39 UTC) #14
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-07 10:38:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/443043003/40001
6 years, 4 months ago (2014-08-07 10:39:40 UTC) #16
hashimoto
6 years, 4 months ago (2014-08-07 11:53:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 manually as 288038 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698