Move omnibox icons to components (1/2)

Move omnibox icons to components (1/2)

To stop depending on resources under chrome/ from AutocompleteMatch.

Add a new file autocomplete_scaled_resources.grdp.
Inline AutocompleteMatch::TypeToLocationBarIcon() to its exclusive user omnibox_view.cc.

BUG=388510
TEST=build

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285870

[hashimoto, 2014-07-24 10:16:00]

blundell@: Please review as an owner of components.
pkasting@: Please review as an owner of autocomplete.

This change is a part of changes to move the icons.
This change just add a new grdp file and add necessary include as preparation.

Since trybots are not happy with binary files moving, icons are moved in
https://codereview.chromium.org/415973005/ separately to minimize the risk of
breaking the tree.

[Jun Mukai, 2014-07-24 17:14:48]

On 2014/07/24 10:16:00, hashimoto wrote:
> blundell@: Please review as an owner of components.
> pkasting@: Please review as an owner of autocomplete.
> 
> This change is a part of changes to move the icons.
> This change just add a new grdp file and add necessary include as preparation.
> 
> Since trybots are not happy with binary files moving, icons are moved in
> https://codereview.chromium.org/415973005/ separately to minimize the risk of
> breaking the tree.

Hi, I am thinking to rename 'autocomplete' to 'omnibox' in components/ side
according to pkasting's comment on https://codereview.chromium.org/415693002/

This does not mean we have to rename chrome/browser/autocomplete (for now),
but it would be great to stop increasing the use of term 'autocomplete'
in new directory like components/.  Can you rename the file as
'omnibox_scaled_resources.grdp' ?

[Peter Kasting, 2014-07-24 18:40:17]

LGTM

https://codereview.chromium.org/415073003/diff/100001/chrome/browser/ui/omnib...
File chrome/browser/ui/omnibox/omnibox_view.cc (right):

https://codereview.chromium.org/415073003/diff/100001/chrome/browser/ui/omnib...
chrome/browser/ui/omnibox/omnibox_view.cc:129: return id;
Nit: Simpler:

  return (id == IDR_OMNIBOX_HTTP) ? IDR_LOCATION_BAR_HTTP : id;

[hashimoto, 2014-07-25 05:23:23]

Renamed to omnibox_scaled_resources.grdp.

https://codereview.chromium.org/415073003/diff/100001/chrome/browser/ui/omnib...
File chrome/browser/ui/omnibox/omnibox_view.cc (right):

https://codereview.chromium.org/415073003/diff/100001/chrome/browser/ui/omnib...
chrome/browser/ui/omnibox/omnibox_view.cc:129: return id;
On 2014/07/24 18:40:17, Peter Kasting wrote:
> Nit: Simpler:
> 
>   return (id == IDR_OMNIBOX_HTTP) ? IDR_LOCATION_BAR_HTTP : id;

Done.

[hashimoto, 2014-07-25 05:23:44]

Colin, could you take a look at this change as an owner of components?

[blundell, 2014-07-25 07:42:43]

//components LGTM pending PK's confirmation that merging the autocomplete and
omnibox code into a single component is desirable long-term.

[Peter Kasting, 2014-07-25 18:20:58]

On 2014/07/25 07:42:43, blundell (OOO until August 6) wrote:
> //components LGTM pending PK's confirmation that merging the autocomplete and
> omnibox code into a single component is desirable long-term.

I think it should be fine.  They used to all be one thing (autocomplete/) in the
browser long ago, the "omnibox" directory arose as we started to rename things
to omnibox, and the rename was never finished, which is why things aren't all
back together as one now.

[hashimoto, 2014-07-28 03:22:59]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-07-28 03:23:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/415073003/160001

[commit-bot: I haz the power, 2014-07-28 06:20:32]

Change committed as 285870