Issue 443019: Fix a memory leak in DnsReloadTimer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443019: Fix a memory leak in DnsReloadTimer (Closed)

Created:
11 years ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a memory leak in DnsReloadTimer TBR=wtc BUG=12710 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33204

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	net/base/host_resolver_proc.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

TBR I didn't read the doc carefully enough to see that I have to delete ...

11 years ago (2009-11-26 12:19:29 UTC) #1

wtc

11 years ago (2009-11-30 19:07:46 UTC) #2

LGTM.

http://codereview.chromium.org/443019/diff/1/2
File net/base/host_resolver_proc.cc (right):

http://codereview.chromium.org/443019/diff/1/2#newcode116
net/base/host_resolver_proc.cc:116: SlotReturnFunction(tls_index_.Get());
This only frees the thread local storage of the current
thread.  The tests need to make sure all the other threads
that use this TLS slot have terminated when we destroy
DnsReloadTimer.  You may want to add a comment to document
this.

Expand Messages | Collapse Messages