Fix a memory leak in DnsReloadTimer

net/base/host_resolver_proc.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/host_resolver_proc.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <ws2tcpip.h>
@@ skipping 95 matching lines @@
   }
 
  private:
   friend struct DefaultSingletonTraits<DnsReloadTimer>;
 
   DnsReloadTimer() {
     tls_index_.Initialize(SlotReturnFunction);
   }
 
   ~DnsReloadTimer() {
+    SlotReturnFunction(tls_index_.Get());

[wtc, 2009/11/30 19:07:46]

This only frees the thread local storage of the current
thread.  The tests need to make sure all the other threads
that use this TLS slot have terminated when we destroy
DnsReloadTimer.  You may want to add a comment to document
this.

     tls_index_.Free();
   }
 
   // We use thread local storage to identify which base::TimeTicks to
   // interact with.
   static ThreadLocalStorage::Slot tls_index_ ;
 
   DISALLOW_COPY_AND_ASSIGN(DnsReloadTimer);
 };
 
@@ skipping 72 matching lines @@
 #endif
 
   if (err)
     return ERR_NAME_NOT_RESOLVED;
 
   addrlist->Adopt(ai);
   return OK;
 }
 
 }  // namespace net