Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 442633003: MacViews: Remove aura dependency from menu_test_base (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Remove aura dependency from menu_test_base The ui_controls_aura implementations either dispatch events via aura::Window::GetHost() (which first does GetRootWindow()), find the root window independently, or else ignore the window argument. So the GetRootWindow call is not required here. BUG=399191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287708

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/views/menu_test_base.cc View 2 chunks +1 line, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
tapted
Hi sky, a small menu CL if you have time - please take a look.
6 years, 4 months ago (2014-08-05 13:46:18 UTC) #1
sky
https://codereview.chromium.org/442633003/diff/1/chrome/browser/ui/views/menu_test_base.cc File chrome/browser/ui/views/menu_test_base.cc (right): https://codereview.chromium.org/442633003/diff/1/chrome/browser/ui/views/menu_test_base.cc#newcode35 chrome/browser/ui/views/menu_test_base.cc:35: GetWidget()->GetNativeWindow(), keycode, false, false, This isn't necessarily the same ...
6 years, 4 months ago (2014-08-05 17:18:33 UTC) #2
tapted
https://codereview.chromium.org/442633003/diff/1/chrome/browser/ui/views/menu_test_base.cc File chrome/browser/ui/views/menu_test_base.cc (right): https://codereview.chromium.org/442633003/diff/1/chrome/browser/ui/views/menu_test_base.cc#newcode35 chrome/browser/ui/views/menu_test_base.cc:35: GetWidget()->GetNativeWindow(), keycode, false, false, On 2014/08/05 17:18:32, sky wrote: ...
6 years, 4 months ago (2014-08-05 23:04:22 UTC) #3
sky
LGTM then
6 years, 4 months ago (2014-08-06 00:29:06 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-06 00:53:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/442633003/1
6 years, 4 months ago (2014-08-06 00:56:21 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 01:59:45 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:30:03 UTC) #8
Message was sent while issue was closed.
Change committed as 287708

Powered by Google App Engine
This is Rietveld 408576698