MacViews: Remove aura dependency from menu_test_base

chrome/browser/ui/views/menu_test_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/views/menu_test_base.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
-#include "ui/aura/window.h"
 #include "ui/base/test/ui_controls.h"
 #include "ui/views/controls/button/menu_button.h"
 #include "ui/views/controls/menu/menu_item_view.h"
 #include "ui/views/controls/menu/menu_runner.h"
 
 MenuTestBase::MenuTestBase()
     : ViewEventTestBase(),
       button_(NULL),
       menu_(NULL),
       last_command_(0) {
 }
 
 MenuTestBase::~MenuTestBase() {
 }
 
 void MenuTestBase::Click(views::View* view, const base::Closure& next) {
   ui_test_utils::MoveMouseToCenterAndPress(
       view,
       ui_controls::LEFT,
       ui_controls::DOWN | ui_controls::UP,
       next);
 }
 
 void MenuTestBase::KeyPress(ui::KeyboardCode keycode,
                             const base::Closure& next) {
   ui_controls::SendKeyPressNotifyWhenDone(
-      GetWidget()->GetNativeView()->GetRootWindow(), keycode, false, false,
+      GetWidget()->GetNativeWindow(), keycode, false, false,

[sky, 2014/08/05 17:18:32]

This isn't necessarily the same thing. Does
ui_controls::SendKeyPressNotifyWhenDone figure out the root correctly?

[tapted, 2014/08/05 23:04:22]

Yeah - I checked they all amount to the same thing:

aurawin first does HWND = window->GetHost() (and the first thing
aura::window::GetHost does is GetRootWindow).

aurax11 ignores the window argument. 

desktop_aurax11 also first does aura::window::GetHost()

factory_ash actually explicitly first calls window->GetRootWindow() as the first
thing

ozone does NOTIMPLEMENTED()

I think that's all of them :)

       false, false, next);
 }
 
 int MenuTestBase::GetMenuRunnerFlags() {
   return views::MenuRunner::HAS_MNEMONICS;
 }
 
 void MenuTestBase::SetUp() {
   button_ = new views::MenuButton(
       NULL, base::ASCIIToUTF16("Menu Test"), this, true);
@@ skipping 35 matching lines @@
   ignore_result(menu_runner_->RunMenuAt(source->GetWidget(),
                                         button_,
                                         bounds,
                                         views::MENU_ANCHOR_TOPLEFT,
                                         ui::MENU_SOURCE_NONE));
 }
 
 void MenuTestBase::ExecuteCommand(int id) {
   last_command_ = id;
 }