Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 442573004: Fix bailout ID for nullary arrow function literals (Closed)

Created:
6 years, 4 months ago by wingo
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev, Michael Starzinger, marja
Project:
v8
Visibility:
Public.

Description

Fix bailout ID for nullary arrow function literals The FunctionState corresponding to the arrow function's body should be torn down before the function literal is allocated, so that the function literal gets a bailout id for the environment in which it appears. We will also need to rewind bailout IDs in the environment of the function literal, to return IDs allocated for arrow function arguments. This will come in the next patch. R=rossberg@chromium.org BUG=v8:3475 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -90 lines) Patch
M src/preparser.h View 2 chunks +75 lines, -90 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wingo
6 years, 4 months ago (2014-08-05 09:37:58 UTC) #1
rossberg
lgtm
6 years, 4 months ago (2014-08-05 13:43:30 UTC) #2
wingo
6 years, 4 months ago (2014-08-05 15:23:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698