Chromium Code Reviews Chromium Code Reviews
Issue 442563002:
Fix getComputedStyle() for area element (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css/area-computedStyle.html |
| diff --git a/LayoutTests/fast/css/area-computedStyle.html b/LayoutTests/fast/css/area-computedStyle.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..97f3150970ee964691ecc3e7e03cebc515d04f40 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css/area-computedStyle.html |
| @@ -0,0 +1,32 @@ |
| +<html> |
|
Inactive
2014/08/06 21:40:43
missing DOCTYPE.
|
| +<head> |
| + <script src="../../resources/js-test.js"></script> |
| +</head> |
| +<script> |
|
Inactive
2014/08/06 21:44:38
Missing a description("...");
|
| +function runtest(){ |
|
Inactive
2014/08/06 21:40:43
missing space before {
|
| + if (!window.testRunner) |
|
Inactive
2014/08/06 21:40:43
not needed.
|
| + return; |
| +testRunner.waitUntilDone(); |
|
Inactive
2014/08/06 21:40:43
window.jsTestIsAsync = true;
|
| +eventSender.mouseMoveTo(75, 75); |
|
Inactive
2014/08/06 21:40:43
You probably need to check if eventSender exists.
Inactive
2014/08/06 21:50:53
This looks unsafe, you would probably get the coor
|
| +} |
| +function hoverFunc(){ |
|
Inactive
2014/08/06 21:40:44
Missing space before {
|
| + var area = document.getElementById('areaTest'); |
| + var s = window.getComputedStyle(area,null); |
|
Inactive
2014/08/06 21:40:43
missing space after comma
Inactive
2014/08/06 21:47:02
What is this variable used for?
|
| + var expectedColor = "rgb(0, 0, 255)"; |
|
Inactive
2014/08/06 21:44:38
Just inline this in the shouldBeEqualToString() ch
|
| + shouldBeEqualToString("window.getComputedStyle(document.getElementById('areaTest'), null).color", expectedColor); |
|
Inactive
2014/08/06 21:40:43
Can you just use "area" ? (Just define area variab
|
| + if (window.testRunner) |
|
Inactive
2014/08/06 21:40:44
finishJSTest();
|
| + testRunner.notifyDone(); |
| +} |
| +</script> |
| +<style type="text/css"> |
|
Inactive
2014/08/06 21:44:37
I don't think you need the type parameter here.
|
| +area:hover{ |
|
Inactive
2014/08/06 21:44:37
missing space before {
|
| + color:blue; |
|
Inactive
2014/08/06 21:44:37
Missing space after ':'
|
| +} |
| +</style> |
| +<body id="body" onload="runtest()"> |
|
Inactive
2014/08/06 21:44:37
Doesn't look like this id is needed.
|
| + <map id="samsung" name="imagemap1"> |
|
Inactive
2014/08/06 21:44:37
Doesn't look like this id is needed. In any case n
|
| + <area id="areaTest", onmouseover="hoverFunc()" shape="rect" coords="0, 0, 100, 100" href="http://www.samsung.com" title="Link1" /> |
|
Inactive
2014/08/06 21:40:43
what is this comma after the id?
|
| + </map> |
| + <img id="img1" src="../../accessibility/resources/cake.png" border="0" align="left" usemap="#imagemap1" /> |
|
Inactive
2014/08/06 21:44:37
Doesn't look like this id is needed.
Inactive
2014/08/06 21:50:53
Any image you could use from the fast/css/resource
|
| +</body> |
| +</html> |
