LayoutTests/fast/css/area-computedStyle.html - Issue 442563002: Fix getComputedStyle() for area element

Side by Side Diff: LayoutTests/fast/css/area-computedStyle.html

Issue 442563002: Fix getComputedStyle() for area element (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix virtual test case Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	Inactive 2014/08/06 21:40:43 missing DOCTYPE. missing DOCTYPE.
	2 <head>

	3 <script src="../../resources/js-test.js"></script>

	4 </head>

	5 <script>
	Inactive 2014/08/06 21:44:38 Missing a description("..."); Missing a description("...");
	6 function runtest(){
	Inactive 2014/08/06 21:40:43 missing space before { missing space before {
	7 if (!window.testRunner)
	Inactive 2014/08/06 21:40:43 not needed. not needed.
	8 return;

	9 testRunner.waitUntilDone();
	Inactive 2014/08/06 21:40:43 window.jsTestIsAsync = true; window.jsTestIsAsync = true;
	10 eventSender.mouseMoveTo(75, 75);
	Inactive 2014/08/06 21:40:43 You probably need to check if eventSender exists. You probably need to check if eventSender exists. Inactive 2014/08/06 21:50:53 This looks unsafe, you would probably get the coor This looks unsafe, you would probably get the coords from the Element you are interested in.
	11 }

	12 function hoverFunc(){
	Inactive 2014/08/06 21:40:44 Missing space before { Missing space before {
	13 var area = document.getElementById('areaTest');

	14 var s = window.getComputedStyle(area,null);
	Inactive 2014/08/06 21:40:43 missing space after comma missing space after comma Inactive 2014/08/06 21:47:02 What is this variable used for? Show quoted text On 2014/08/06 21:40:43, Chris Dumez wrote: > missing space after comma What is this variable used for?
	15 var expectedColor = "rgb(0, 0, 255)";
	Inactive 2014/08/06 21:44:38 Just inline this in the shouldBeEqualToString() ch Just inline this in the shouldBeEqualToString() check
	16 shouldBeEqualToString("window.getComputedStyle(document.getElementById('areaTes t'), null).color", expectedColor);
	Inactive 2014/08/06 21:40:43 Can you just use "area" ? (Just define area variab Can you just use "area" ? (Just define area variable at global scope).
	17 if (window.testRunner)
	Inactive 2014/08/06 21:40:44 finishJSTest(); finishJSTest();
	18 testRunner.notifyDone();

	19 }

	20 </script>

	21 <style type="text/css">
	Inactive 2014/08/06 21:44:37 I don't think you need the type parameter here. I don't think you need the type parameter here.
	22 area:hover{
	Inactive 2014/08/06 21:44:37 missing space before { missing space before {
	23 color:blue;
	Inactive 2014/08/06 21:44:37 Missing space after ':' Missing space after ':'
	24 }

	25 </style>

	26 <body id="body" onload="runtest()">
	Inactive 2014/08/06 21:44:37 Doesn't look like this id is needed. Doesn't look like this id is needed.
	27 <map id="samsung" name="imagemap1">
	Inactive 2014/08/06 21:44:37 Doesn't look like this id is needed. In any case n Doesn't look like this id is needed. In any case not samsung.
	28 <area id="areaTest", onmouseover="hoverFunc()" shape="rect" coords="0, 0, 100, 100" href="http://www.samsung.com" title="Link1" />
	Inactive 2014/08/06 21:40:43 what is this comma after the id? what is this comma after the id?
	29 </map>

	30 <img id="img1" src="../../accessibility/resources/cake.png" border="0" align= "left" usemap="#imagemap1" />
	Inactive 2014/08/06 21:44:37 Doesn't look like this id is needed. Doesn't look like this id is needed. Inactive 2014/08/06 21:50:53 Any image you could use from the fast/css/resource Any image you could use from the fast/css/resources/ folder instead of going into accessibility?
	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/accessibility/image-map2-expected.txt ('k') | LayoutTests/fast/css/area-computedStyle-expected.txt » ('j') | Source/core/css/html.css » ('J')