Issue 442553002: Remove unneccessary arguments from extensions::DispatcherDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 442553002: Remove unneccessary arguments from extensions::DispatcherDelegate (Closed)

Created:
6 years, 4 months ago by ericzeng

Modified:
6 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove unneccessary arguments from extensions::DispatcherDelegate This CL removes three arguments from the RequireAdditionalModules method since only the ScriptContext is needed to get those values. BUG=todo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287480

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -14 lines)			Patch
M	chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	extensions/renderer/dispatcher.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	extensions/renderer/dispatcher_delegate.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/442553002/1

6 years, 4 months ago (2014-08-04 23:13:01 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...

6 years, 4 months ago (2014-08-05 00:45:32 UTC) #5

Message was sent while issue was closed.

Change committed as 287480

Expand Messages | Collapse Messages