Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10367)

Unified Diff: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

Issue 442553002: Remove unneccessary arguments from extensions::DispatcherDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
index cdb175adb3b15c33f3d903d67f3190bda8178a30..253dd2c13bf985f20e5af937e8a086ddbd069889 100644
--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
@@ -262,10 +262,11 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(
}
void ChromeExtensionsDispatcherDelegate::RequireAdditionalModules(
- extensions::ModuleSystem* module_system,
- const extensions::Extension* extension,
- extensions::Feature::Context context_type,
+ extensions::ScriptContext* context,
bool is_within_platform_app) {
+ extensions::ModuleSystem* module_system = context->module_system();
+ extensions::Feature::Context context_type = context->context_type();
+
// TODO(kalman, fsamuel): Eagerly calling Require on context startup is
// expensive. It would be better if there were a light way of detecting when
// a webview or appview is created and only then set up the infrastructure.
@@ -277,6 +278,8 @@ void ChromeExtensionsDispatcherDelegate::RequireAdditionalModules(
module_system->Require("windowControls");
}
+ const extensions::Extension* extension = context->extension();
+
// We used to limit WebView to |BLESSED_EXTENSION_CONTEXT| within platform
// apps. An ext/app runs in a blessed extension context, if it is the active
// extension in the current process, in other words, if it is loaded in a top
« no previous file with comments | « chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698