Issue 44253003: Remove virtual destructors for several graphics classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44253003: Remove virtual destructors for several graphics classes (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
Stephen Chennney, abarth-chromium

CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove virtual destructors for several graphics classes Remove destructors for several graphics classes as these were empty and marked as virtual. This avoids creating unnecessary vtables since these classes are never subclasses nor do they have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160590

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -10 lines)			Patch
M	Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/platform/graphics/skia/OpaqueRegionSkia.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/platform/graphics/skia/OpaqueRegionSkia.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen Chennney

LGTM if the bots agree. I've added Android, which you should always do because it ...

7 years, 1 month ago (2013-10-25 15:13:15 UTC) #2

Inactive

On 2013/10/25 15:13:15, Stephen Chenney wrote: > LGTM if the bots agree. I've added Android, ...

7 years, 1 month ago (2013-10-25 15:36:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/44253003/1

7 years, 1 month ago (2013-10-25 15:38:20 UTC) #4

Message was sent while issue was closed.

Change committed as 160590

Expand Messages | Collapse Messages