Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp - Issue 44253003: Remove virtual destructors for several graphics classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

Issue 44253003: Remove virtual destructors for several graphics classes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.h ('k') | Source/core/platform/graphics/skia/OpaqueRegionSkia.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

diff --git a/Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp b/Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

index 259479273e4f698b6e80da38f1b03b39b2548928..a2ff2bb61a88705f09eeb2fcdaa0526610573e2e 100644

--- a/Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

+++ b/Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

@@ -367,10 +367,6 @@ HarfBuzzShaper::HarfBuzzShaper(const Font* font, const TextRun& run)

setFontFeatures();

}

-HarfBuzzShaper::~HarfBuzzShaper()

static void normalizeSpacesAndMirrorChars(const UChar* source, unsigned length, UChar* destination, unsigned* destinationLength, HarfBuzzShaper::NormalizeMode normalizeMode)

{

int position = 0;

« no previous file with comments | « Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.h ('k') | Source/core/platform/graphics/skia/OpaqueRegionSkia.h » ('j') | no next file with comments »