Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 442493002: [chromedriver] Allow testing using newer versions than what Omaha reports (Closed)

Created:
6 years, 4 months ago by samuong
Modified:
6 years, 4 months ago
Reviewers:
stgao
CC:
chromium-reviews, jbudorick, klundberg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Allow testing using newer versions than what Omaha reports BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287481

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use map instead of for loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
samuong
6 years, 4 months ago (2014-08-04 20:40:22 UTC) #1
stgao
https://codereview.chromium.org/442493002/diff/1/chrome/test/chromedriver/test/run_py_tests.py File chrome/test/chromedriver/test/run_py_tests.py (right): https://codereview.chromium.org/442493002/diff/1/chrome/test/chromedriver/test/run_py_tests.py#newcode740 chrome/test/chromedriver/test/run_py_tests.py:740: self.assertTrue(self._compareVersions(from_omaha, from_device) <= 0) Maybe we could do it ...
6 years, 4 months ago (2014-08-04 20:51:25 UTC) #2
samuong
On 2014/08/04 20:51:25, Shuotao wrote: > https://codereview.chromium.org/442493002/diff/1/chrome/test/chromedriver/test/run_py_tests.py > File chrome/test/chromedriver/test/run_py_tests.py (right): > > https://codereview.chromium.org/442493002/diff/1/chrome/test/chromedriver/test/run_py_tests.py#newcode740 > ...
6 years, 4 months ago (2014-08-04 22:57:09 UTC) #3
samuong
https://codereview.chromium.org/442493002/diff/1/chrome/test/chromedriver/test/run_py_tests.py File chrome/test/chromedriver/test/run_py_tests.py (right): https://codereview.chromium.org/442493002/diff/1/chrome/test/chromedriver/test/run_py_tests.py#newcode740 chrome/test/chromedriver/test/run_py_tests.py:740: self.assertTrue(self._compareVersions(from_omaha, from_device) <= 0) On 2014/08/04 20:51:25, Shuotao wrote: ...
6 years, 4 months ago (2014-08-04 22:57:28 UTC) #4
stgao
lgtm
6 years, 4 months ago (2014-08-04 23:24:45 UTC) #5
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 4 months ago (2014-08-04 23:24:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/442493002/20001
6 years, 4 months ago (2014-08-04 23:25:42 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 07:44:28 UTC) #8
Message was sent while issue was closed. 
Change committed as 287481

Powered by Google App Engine
This is Rietveld 408576698