Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 442493002: [chromedriver] Allow testing using newer versions than what Omaha reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use map instead of for loop Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 33a73191b36ba684df1f791802e8e9fa329a2cff..71b225a8b60b2bd336165cc2d2132ec836cc90e7 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -735,8 +735,9 @@ class ChromeDriverAndroidTest(ChromeDriverBaseTest):
for v in l['versions']:
if (('stable' in v['channel'] and 'stable' in _ANDROID_PACKAGE_KEY) or
('beta' in v['channel'] and 'beta' in _ANDROID_PACKAGE_KEY)):
- self.assertEquals(v['version'],
- self._driver.capabilities['version'])
+ omaha = map(int, v['version'].split('.'))
+ device = map(int, self._driver.capabilities['version'].split('.'))
+ self.assertTrue(omaha <= device)
return
raise RuntimeError('Malformed omaha JSON')
except urllib2.URLError as e:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698