Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 442343006: Mac: Don't perform unnecessary star decoration redraws. (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Mike Wittman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac: Don't perform unnecessary star decoration redraws. If the star in the Location Bar is already in the correct state, then there's no need to perform a complete redraw. This was responsible for ~50% of extraneous location bar redraws, which was consuming ~5% of cpu cycles on start up. BUG=393819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
erikchen
shess: Please review.
6 years, 4 months ago (2014-08-06 21:20:35 UTC) #1
Scott Hess - ex-Googler
lgtm
6 years, 4 months ago (2014-08-06 21:24:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/442343006/1
6 years, 4 months ago (2014-08-06 21:25:51 UTC) #3
Scott Hess - ex-Googler
Err, sorry if lgtm+cg was forward of me. I was on autopilot... On Wed, Aug ...
6 years, 4 months ago (2014-08-06 21:30:55 UTC) #4
erikchen
It was unexpected, but it also saved me a mouse click. :D
6 years, 4 months ago (2014-08-06 21:32:24 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 23:48:27 UTC) #6
Message was sent while issue was closed.
Change committed as 287902

Powered by Google App Engine
This is Rietveld 408576698