chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm - Issue 442343006: Mac: Don't perform unnecessary star decoration redraws.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 442343006: Mac: Don't perform unnecessary star decoration redraws. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

index d05c785f9ecb81f701ac048c227b333100dbf1ce..02e49fdd19408340da87faf59dbdd423a1e4b1c0 100644

--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

@@ -339,6 +339,9 @@ bool LocationBarViewMac::IsEditable() {

}

void LocationBarViewMac::SetStarred(bool starred) {

+ if (star_decoration_->starred() == starred)

+ return;

star_decoration_->SetStarred(starred);

UpdateStarDecorationVisibility();

OnDecorationsChanged();

« no previous file with comments | « no previous file | no next file » | no next file with comments »