Source/core/dom/Document.cpp - Issue 442343002: Creating custom element should not be case sensitive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 442343002: Creating custom element should not be case sensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/custom/custom-element-name-sensivity.html ('K') | « LayoutTests/fast/dom/custom/custom-element-name-sensivity-expected.txt ('k') | Source/core/dom/custom/CustomElementRegistrationContext.cpp » ('j') | Source/core/dom/custom/CustomElementRegistrationContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index d721e4f70ef5cc5e9ed19d164121c13196463f12..0782edfb0cc0f597381a34bf5c8b8c6acf382fba 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -780,7 +780,7 @@ PassRefPtrWillBeRawPtr<Element> Document::createElement(const AtomicString& loca

RefPtrWillBeRawPtr<Element> element;

if (CustomElement::isValidName(localName) && registrationContext()) {

- element = registrationContext()->createCustomTagElement(*this, QualifiedName(nullAtom, localName, xhtmlNamespaceURI));

+ element = registrationContext()->createCustomTagElement(*this, QualifiedName(nullAtom, isHTMLDocument() ? localName.lower() : localName, xhtmlNamespaceURI));

dominicc (has gone to gerrit) 2014/08/11 06:05:27 Could we factor out a little function and eliminat

deepak.sa 2014/08/11 10:32:50 Done.

} else {

element = createElement(localName, exceptionState);

if (exceptionState.hadException())