Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5245)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments addressed. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index 5cf23b164553635aedf69580b720958c989b7da6..739cb4835cd6c42f85986b131a0d6b9eaec60638 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -65,12 +65,12 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
// Open or reveal DevTools window, and perform the specified action.
static DevToolsWindow* OpenDevToolsWindow(
- content::RenderViewHost* inspected_rvh,
+ content::WebContents* inspected_web_contents,
const DevToolsToggleAction& action);
// Open or reveal DevTools window, with no special action.
static DevToolsWindow* OpenDevToolsWindow(
- content::RenderViewHost* inspected_rvh);
+ content::WebContents* inspected_web_contents);
// Perform specified action for current WebContents inside a |browser|.
// This may close currently open DevTools window.
@@ -89,8 +89,9 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
Profile* profile,
content::DevToolsAgentHost* worker_agent);
- static void InspectElement(
- content::RenderViewHost* inspected_rvh, int x, int y);
+ static void InspectElement(content::WebContents* inspected_web_contents,
+ int x,
+ int y);
// Sets closure to be called after load is done. If already loaded, calls
// closure immediately.
@@ -199,12 +200,12 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
DevToolsWindow(Profile* profile,
const GURL& frontend_url,
- content::RenderViewHost* inspected_rvh,
+ content::WebContents* inspected_web_contents,
bool can_dock);
static DevToolsWindow* Create(Profile* profile,
const GURL& frontend_url,
- content::RenderViewHost* inspected_rvh,
+ content::WebContents* inspected_web_contents,
bool shared_worker_frontend,
bool external_frontend,
bool can_dock,
@@ -219,7 +220,7 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
static DevToolsWindow* AsDevToolsWindow(content::WebContents*);
static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile);
static DevToolsWindow* ToggleDevToolsWindow(
- content::RenderViewHost* inspected_rvh,
+ content::WebContents* web_contents,
bool force_open,
const DevToolsToggleAction& action,
const std::string& settings);

Powered by Google App Engine
This is Rietveld 408576698