chrome/browser/devtools/devtools_targets_ui.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_target_impl.cc ('K') | « chrome/browser/devtools/devtools_target_impl.cc ('k') | chrome/browser/devtools/devtools_window.h » ('j') | chrome/browser/devtools/devtools_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_targets_ui.cc

diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc

index e2161c0845d2e06232d3c6e41eec269dab39654a..555ad222ea97777657fe96e7534f2c0d649deeff 100644

--- a/chrome/browser/devtools/devtools_targets_ui.cc

+++ b/chrome/browser/devtools/devtools_targets_ui.cc

@@ -138,7 +138,7 @@ void RenderViewHostTargetsUIHandler::UpdateTargets() {

std::map<std::string, base::DictionaryValue*> id_to_descriptor;

DevToolsTargetImpl::List targets =

- DevToolsTargetImpl::EnumerateRenderViewHostTargets();

+ DevToolsTargetImpl::EnumerateWebContentsTargets();

STLDeleteValues(&targets_);

for (DevToolsTargetImpl::List::iterator it = targets.begin();