Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 442133002: Typecheck chrome://downloads using CompilerPass.java (Closed)

Created:
6 years, 4 months ago by Vitaly Pavlenko
Modified:
6 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Typecheck chrome://downloads using CompilerPass.java R=dbeam@chromium.org BUG=393873 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287836

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes after comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -12 lines) Patch
M chrome/browser/resources/downloads/downloads.js View 1 14 chunks +45 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vitaly Pavlenko
6 years, 4 months ago (2014-08-05 22:51:54 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/442133002/diff/1/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/442133002/diff/1/chrome/browser/resources/downloads/downloads.js#newcode486 chrome/browser/resources/downloads/downloads.js:486: .addListener( var media = '(-webkit-min-device-pixel-ratio:' + scale + ...
6 years, 4 months ago (2014-08-05 23:14:33 UTC) #2
Vitaly Pavlenko
https://codereview.chromium.org/442133002/diff/1/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/442133002/diff/1/chrome/browser/resources/downloads/downloads.js#newcode486 chrome/browser/resources/downloads/downloads.js:486: .addListener( On 2014/08/05 23:14:33, Dan Beam wrote: > var ...
6 years, 4 months ago (2014-08-06 00:28:53 UTC) #3
Vitaly Pavlenko
https://codereview.chromium.org/442133002/diff/1/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/442133002/diff/1/chrome/browser/resources/downloads/downloads.js#newcode754 chrome/browser/resources/downloads/downloads.js:754: } On 2014/08/05 23:14:33, Dan Beam wrote: > nit: ...
6 years, 4 months ago (2014-08-06 00:29:25 UTC) #4
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-06 15:03:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/442133002/20001
6 years, 4 months ago (2014-08-06 15:04:10 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 19:59:59 UTC) #7
Message was sent while issue was closed. 
Change committed as 287836

Powered by Google App Engine
This is Rietveld 408576698